Skip to content

enable #![no_std]#52

Closed
jayakasadev wants to merge 3 commits intochronotope:mainfrom
jayakasadev:main
Closed

enable #![no_std]#52
jayakasadev wants to merge 3 commits intochronotope:mainfrom
jayakasadev:main

Conversation

@jayakasadev
Copy link

allow users to use humantime in bare-metal environments

@djc
Copy link
Member

djc commented Apr 29, 2025

Thanks for contributing! I think it would be nice to offer no_std support but I'd like to split this up in several parts. First off, I suggest you do a PR that enables clippy::std_instead_of_core and clippy::std_instead_of_alloc the crate root and fixes all of the resulting warnings.

Second, given that this crate now lives in the chronotope org, I'm ambivalent on using the time crate. Would you be open to using chrono's no_std support instead?

Third, I'd like to understand the MSRV impact given that CI failed.

Fourth, it's not obvious to me that this is worth a semver-incompatible API change. Do you think we could make this change additive instead?

@jayakasadev
Copy link
Author

@djc does this align with your expectations for part 1 of the change?
#53

@djc
Copy link
Member

djc commented Apr 30, 2025

Let's get #53 merged first?

@jayakasadev
Copy link
Author

Going to close this since the work is being split up.

@jayakasadev jayakasadev closed this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants