feat: switch to 30 day month and 365 day year with leapless feature#63
Closed
elrafoon wants to merge 1 commit intochronotope:mainfrom
Closed
feat: switch to 30 day month and 365 day year with leapless feature#63elrafoon wants to merge 1 commit intochronotope:mainfrom
leapless feature#63elrafoon wants to merge 1 commit intochronotope:mainfrom
Conversation
There are valid scenarios when 365.25day year and 30.44day month are unusable or unexpected.
Member
|
I don't think Cargo features are a good fit for API like this, because it subtly but drastically changes behavior at a distance when a crate that enables this feature is pulled into your dependency graph. It's also clearly not a common requirement, since this is the first time it has come up (as far as I know). As such, I don't think it makes sense to merge this. |
Author
|
Ok, understand, I also thought about that dependency graph problem. So would you accept a new patch that would extend |
Member
|
Maybe, but it still feels like it would be pretty invasive relative to how niche your desired feature is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
please consider merging this patch, that allows switching between 365.25/365 days per year and 30.44/30 days per month by enabling feature
leapless.I'm using humantime in project working with timeseries data, and the classic interpretation of 365d/y and 30d/m is required there.
I also think this can be a very common requirement in many other projects.
Thank you.