Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1: Nested Flexs with IE 11 tends to cause width issue, this was causing a problem with the Month/Year Selection Example image of just the stock repo site showing the problem in IE 11, I added a flex-fix class and just passed it into that specific spot because just trying to avoid anything overly complex because there isn't a consistent way of fixing this issue.
Issue 2: IE 11 does not always respect heights well with certain elements, the styling change from absolute and pushing it right to relative and just pulling in the margin is a much more consistent way of getting this affect.
Minor Issue: I noticed some duplicate class names in a file and fixed them, flex was used multiple times.