Remove testOnly_getNumRenderObjects and consolidate GeometryTests #342
+161
−221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove testOnly_getNumRenderObjects from SimulationFacade.h interface - Remove testOnly_getNumRenderObjects from SimulationFacadeImpl - Remove testOnly_getNumRenderObjects from EngineWorker - Remove testOnly_getNumRenderObjects from SimulationCudaFacade - Remove duplicate getNumRenderObjects_* tests, keep enhanced copyBuffers_* tests - Add copyBuffers_multipleParticles, copyBuffers_triangularCluster, copyBuffers_creature tests - Extend copyBuffers_cellsWithConnections to use downloadSelectedConnectionData - All 15 GeometryTests pass, 870 EngineTests pass (867 passed, 3 skipped) Co-authored-by: chrxh <[email protected]>
Copilot
AI
changed the title
[WIP] Remove test access and rewrite GeometryTests for getNumRenderObjects
Remove testOnly_getNumRenderObjects and consolidate GeometryTests
Jan 5, 2026
chrxh
reviewed
Jan 5, 2026
source/EngineTests/GeometryTests.cpp
Outdated
| auto numObjects = _simulationFacade->testOnly_getNumRenderObjects(); | ||
| _simulationFacade->tryCopyBuffersFromCudaToOpenGL(geometryBuffers, visibleWorldRect); | ||
|
|
||
| auto numObjects = geometryBuffers->getNumObjects(); |
Owner
There was a problem hiding this comment.
@copilot Check also the buffer entries by using downloadSelectedObjectData (see the other tests selectedObjectData*)
Contributor
Author
There was a problem hiding this comment.
Added buffer verification via downloadSelectedObjectData in commit b9dbca1. The test now selects the cell and verifies selectedObjects.size() == 1.
…lectedObjectData Co-authored-by: chrxh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testOnly_getNumRenderObjectsfromSimulationFacade.hinterfacetestOnly_getNumRenderObjectsfromSimulationFacadeImpl.handSimulationFacadeImpl.cpptestOnly_getNumRenderObjectsfromEngineWorker.handEngineWorker.cpptestOnly_getNumRenderObjectsfromSimulationCudaFacade.cuhandSimulationCudaFacade.cugetNumRenderObjects_*tests (kept enhancedcopyBuffers_*tests)copyBuffers_multipleParticles,copyBuffers_triangularCluster,copyBuffers_creaturecopyBuffers_cellsWithConnectionswithdownloadSelectedConnectionDatabuffer inspectioncopyBuffers_singleCellwithdownloadSelectedObjectDatabuffer inspectionOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.