Use binary icon for binary file types #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
added
type: feature
chshersh
reviewed
Jan 11, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Great stuff! Left a few comments and suggestions on how to improve things.
Co-authored-by: Dmitrii Kovanikov <[email protected]>
chshersh
approved these changes
Jan 12, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Hey @heathhenley,
Impressive work!
Indeed, I do like the new shape of file_contents more as it better reflects the actual underlying model.
Indeed, the code became slightly more complex. I have a few ideas on how to fix that but I propose to handle them under separate refactoring issues.
Thanks for implementing this feature! 🏆
Comment on lines
+104
to
+107
| | File (name, contents) -> ( | ||
| match Lazy.force contents with | ||
| | Fs.Text _ -> file_char ^ " " ^ pad name | ||
| | Fs.Binary -> bin_char ^ " " ^ pad name) |
Owner
There was a problem hiding this comment.
I like how it looks, this is pretty neat!
This was referenced Jan 12, 2025
Owner
|
Hey @heathhenley, I made a couple of follow-up refactoring issues to decrease some tech debt:
Feel free to grab them in no particular order 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at last part of #8
Kind of unrelated but in the docs it suggests to use
Lazy.tinstead oflazy_thttps://ocaml.org/manual/5.3/api/Lazy.html (I don't know if there was a reason to uselazy_t- this is the first time I've usedlazyso could be way off)The issue that I see with this approach is that now we
batthe files twice - maybe that's ok? If not let me know if you see a way to set it up so that it's lazily evaluated when either contents or type is needed, but they both get set when that happens. I tried returning a tuple fromread_file_contents- but I had some trouble getting to work right withlazy.This is what it looks like:
