Refactor horizontal rendering slightly #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
added
type: refactoring
chshersh
reviewed
Feb 2, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Good stuff!
It looked better in my imagination 😅
I proposed to make a few more refactorings to improve things.
heathhenley
force-pushed
the
dev_hh_map_with_fold
branch
from
0bfbdc4 to
98a8105
Compare
chshersh
reviewed
Feb 2, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
A few minor comments but overall looks great!
Co-authored-by: Dmitrii Kovanikov <[email protected]>
Co-authored-by: Dmitrii Kovanikov <[email protected]>
heathhenley
force-pushed
the
dev_hh_map_with_fold
branch
from
1c9543a to
f1cade3
Compare
chshersh
approved these changes
Feb 2, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Looks great, thank you!
Those functions will become even more useful over time 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
Let me know what you think!