-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add Code of Conduct and Contributing guide #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
heathhenley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I wonder if we need some dev notes for non-code things that might not be obvious when hacking on this project?
edit: ignore my question :P
What kind of things do you mean here? |
|
@heathhenley actually nevermind I just noticed that what I thought about was already in the README 😌 |
|
Looks good to me! 👍 |
|
Looks good to me 🚀 |
|
Thanks everyone for the quick review! Since we got approvals from everyone, I'll merge it earlier. There's always a possibility to discuss and change it later if anything comes up. |
|
|
||
| That's all so far! | ||
|
|
||
| > ![NOTE] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be [!NOTE]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistakes were made 🫠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for noticing! Done in 8369e37
Adding some guidelines for ensuring we don't stress from working on this project (stressing out about breaking the rules doesn't count).
TL;DR: Be respectful, behave like an adult and prefer discussing issues first to avoid conflicts and unexpected ambiguity.
Please, read it and let me know if the wording doesn't make sense or if something is unclear.
cc @heathhenley @thezbm @loadre @qexat since you contributed in the past and may want to contribute in the future
I'll keep this PR open for 1 week to give you folks some time to review and discuss, and then I'll merge it on February 9th.
As for long-term goals, I plan to work on this project today, tomorrow, in one week, in one month and this year. Then we'll see.
Maybe Microsoft will recognise this wholesome effort and pay me huge bucks. But to be realistic, most likely, people will try GitHub TUI and just start constantly complaining a lot about something not working.
My plan is to make the 1.0 release this year (see milestones for the roadmap).
The current stage is pre-alpha. I'll continue to exercise my power of BDFL and push to
maindirectly until alpha is done. Obviously, I'll be reasonable to avoid conflicts with current PRs.Then, I'll slow down and start working through PRs (if we still have contributors who can review the code).
Happy to discuss further!