Refactor init #54
Merged
Refactor init #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chshersh
added
type: refactoring
chshersh
requested review from
chshersh and
heathhenley
and removed request for
heathhenley
chshersh
reviewed
Feb 15, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Nice refactoring!
That's pretty much what I had in mind. Thanks for the cleanup!
I left a few minor comments but overall looks good 👍🏻
heathhenley
approved these changes
Feb 15, 2025
Collaborator
heathhenley
left a comment
heathhenley
left a comment
There was a problem hiding this comment.
LGTM! Going to get to test it out right away in #53 if we decide to add another cl arg
chshersh
approved these changes
Feb 17, 2025
Owner
chshersh
left a comment
chshersh
left a comment
There was a problem hiding this comment.
Thanks for the refactoring, it'll make things easier in the future!
@heathhenley feel free to try it out :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36
What do you think? @chshersh