Skip to content

Show specific release#106

Open
obstschale wants to merge 3 commits into
masterfrom
issue-84-show-specific-release
Open

Show specific release#106
obstschale wants to merge 3 commits into
masterfrom
issue-84-show-specific-release

Conversation

@obstschale
Copy link
Copy Markdown
Member

Summary

  • output unreleased changes as Markdown from the show command
  • add optional version argument to print one exact release section from CHANGELOG.md
  • return a non-zero error when the requested release is missing

Closes #84

Tests

  • vendor/bin/phpunit tests/Feature/Commands/ShowTest.php --colors=always

@obstschale
Copy link
Copy Markdown
Member Author

Code review

  1. general (medium) - ShowCommand.php: generateContent() duplicates the markdown generation logic from ReleaseCommand; extracting a shared formatter would avoid future inconsistencies.
  2. general (low) - ShowCommand.php: parsing unreleased LogEntry files is duplicated from ReleaseCommand; consider moving that mapping into ChangesDirectory.

Checks: code review inspected origin/master...HEAD. No automated checks were run as part of this review.

@obstschale
Copy link
Copy Markdown
Member Author

Updated the PR with a refactor that extracts shared changelog markdown generation into ChangelogMarkdownGenerator and wires both show and release through it.

Tests:

  • vendor/bin/phpunit tests/Feature/Commands/ShowTest.php tests/Feature/Commands/ReleaseTest.php --colors=always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show specific release

1 participant