Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber 2.4.0 support #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

Cucumber 2.4.0 support #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12407fc
Cucumber 2.4.0 support
Jul 13, 2017
2d41087
Merge pull request #17 Cucumber 2.4.0 support
Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ namespace :generate do

task :cucumber do
cucumber = "#{Gem.loaded_specs['cucumber'].gem_dir}/bin/cucumber"
run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber acceptance/cucumber"
# run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber acceptance/cucumber"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not commit commented-out code.

run_ruby_acceptance "-rci/reporter/rake/cucumber_loader -S #{cucumber} --format CI::Reporter::Cucumber"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of moving the directory, I'd rather add -r acceptance/cucumber/step_definitions/development_steps.rb to this command.

end

task :all => [:clean, :cucumber]
Expand Down
2 changes: 1 addition & 1 deletion ci_reporter_cucumber.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
spec.test_files = spec.files.grep(%r{^(test|spec|features|acceptance)/})
spec.require_paths = ["lib"]

spec.add_dependency "cucumber", "~> 1.3.3"
spec.add_dependency "cucumber", "~> 2.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to be as drastic with the change here. It appears that ">= 1.3.3", "< 3.0.0" should be fine.

spec.add_dependency "ci_reporter", "~> 2.0"

spec.add_development_dependency "bundler", "~> 1.6"
Expand Down
0 acceptance/cucumber/cucumber_example.feature → features/cucumber_example.feature
View file
Open in desktop
File renamed without changes.
0 ...ber/step_definitions/development_steps.rb → ...res/step_definitions/development_steps.rb
View file
Open in desktop
File renamed without changes.
Empty file added features/support/env.rb
View file
Open in desktop
Empty file.