[Snyk] Security upgrade transformers from 4.44.2 to 5.0.0rc1 - #42
Conversation
…ilities The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-TRANSFORMERS-14564337
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Summary of ChangesHello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates a critical security update by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
There was a problem hiding this comment.
Code Review
This pull request from Snyk upgrades the transformers library to version 5.0.0rc1 to resolve a security vulnerability. My review highlights a potential issue with this change: the new version is a release candidate, not a stable release. Using a pre-release version, especially for a major version update, carries a risk of instability and breaking changes. I've added a comment to the requirements.txt file recommending caution and suggesting an update to a stable version once it becomes available.
| torch==2.4.1 | ||
| tqdm==4.66.5 | ||
| transformers==4.44.2 | ||
| transformers==5.0.0rc1 |
There was a problem hiding this comment.
The transformers dependency is being upgraded to 5.0.0rc1, which is a release candidate (pre-release) version. Using pre-release versions, especially for a major version bump (from 4.x to 5.x), can introduce instability and breaking changes. While this is likely necessary to patch a security vulnerability, it's advisable to switch to the stable 5.0.0 release as soon as it becomes available to ensure the stability of this example.
|
| Status | Scanner | Total (0) | ||||
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| transformers==5.0.0rc1 | ||
| triton==3.0.0 | ||
| trl==0.10.1 |
There was a problem hiding this comment.
Avoid unsatisfiable transformers upgrade
Pinning transformers to 5.0.0rc1 conflicts with the other pins in this file: both trl==0.10.1 (line 78) and unsloth==2024.8 (line 82) still declare transformers<5 in their metadata, so pip install -r requirements.txt will now raise a resolver error before the example environment can be created. Please keep transformers <5 or upgrade the dependent packages together.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
examples/third_party/unsloth/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Deserialization of Untrusted Data