Skip to content

[Snyk] Security upgrade transformers from 4.44.2 to 5.0.0rc1 - #42

Open
arthrod wants to merge 1 commit into
mainfrom
snyk-fix-9e87060ae52a1e694cbca03ecf83619d
Open

[Snyk] Security upgrade transformers from 4.44.2 to 5.0.0rc1#42
arthrod wants to merge 1 commit into
mainfrom
snyk-fix-9e87060ae52a1e694cbca03ecf83619d

Conversation

@arthrod

@arthrod arthrod commented Dec 29, 2025

Copy link
Copy Markdown
Collaborator

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • examples/third_party/unsloth/requirements.txt
⚠️ Warning
multiprocess 0.70.15 has requirement dill>=0.3.7, but you have dill 0.3.6.

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Deserialization of Untrusted Data

…ilities

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-TRANSFORMERS-14564337
@coderabbitai

coderabbitai Bot commented Dec 29, 2025

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snyk-fix-9e87060ae52a1e694cbca03ecf83619d

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates a critical security update by upgrading the transformers dependency to its latest release candidate version. This ensures that the project benefits from the most recent security patches and improvements, mitigating a detected vulnerability without requiring manual intervention.

Highlights

  • Security Upgrade: This pull request is an automated security upgrade initiated by Snyk to address 1 vulnerability in the project's pip dependencies.
  • Dependency Update: The transformers library has been upgraded from version 4.44.2 to 5.0.0rc1.
  • Affected File: The change is localized to the examples/third_party/unsloth/requirements.txt file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@openhands-ai

openhands-ai Bot commented Dec 29, 2025

Copy link
Copy Markdown

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • CLA Assistant

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #42 at branch `snyk-fix-9e87060ae52a1e694cbca03ecf83619d`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Snyk upgrades the transformers library to version 5.0.0rc1 to resolve a security vulnerability. My review highlights a potential issue with this change: the new version is a release candidate, not a stable release. Using a pre-release version, especially for a major version update, carries a risk of instability and breaking changes. I've added a comment to the requirements.txt file recommending caution and suggesting an update to a stable version once it becomes available.

torch==2.4.1
tqdm==4.66.5
transformers==4.44.2
transformers==5.0.0rc1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The transformers dependency is being upgraded to 5.0.0rc1, which is a release candidate (pre-release) version. Using pre-release versions, especially for a major version bump (from 4.x to 5.x), can introduce instability and breaking changes. While this is likely necessary to patch a security vulnerability, it's advisable to switch to the stable 5.0.0 release as soon as it becomes available to ensure the stability of this example.

@arthrod

arthrod commented Dec 29, 2025

Copy link
Copy Markdown
Collaborator Author

⚠️ Snyk checks are incomplete.

Status Scanner Critical High Medium Low Total (0)
⚠️ Open Source Security 0 0 0 0 See details

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +76 to 78
transformers==5.0.0rc1
triton==3.0.0
trl==0.10.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unsatisfiable transformers upgrade

Pinning transformers to 5.0.0rc1 conflicts with the other pins in this file: both trl==0.10.1 (line 78) and unsloth==2024.8 (line 82) still declare transformers<5 in their metadata, so pip install -r requirements.txt will now raise a resolver error before the example environment can be created. Please keep transformers <5 or upgrade the dependent packages together.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants