Skip to content
This repository was archived by the owner on Dec 4, 2025. It is now read-only.

Feature/legend filter - #238

Open
romsson wants to merge 36 commits into
betafrom
feature/legend-filter
Open

Feature/legend filter#238
romsson wants to merge 36 commits into
betafrom
feature/legend-filter

Conversation

@romsson

@romsson romsson commented Apr 5, 2016

Copy link
Copy Markdown
Collaborator

screen shot 2016-04-05 at 3 20 49 pm

  • Filters the VisTK scatterplot based on legend's product category being clicked
  • The legend visually reflects the current selection by highlighting the currently selected product
  • The filter can be disabled by clicking on the currently selected legend key
  • Current version does not support time change, text filter, page refresh, and also does not filter the table

@romsson

romsson commented Apr 8, 2016

Copy link
Copy Markdown
Collaborator Author

network

  • Code cleanup
  • Works for network visualization

@makmanalp
makmanalp force-pushed the feature/legend-filter branch from 0d075ec to 562a9a6 Compare April 11, 2016 20:13
@makmanalp

Copy link
Copy Markdown
Contributor

Rebasing the commits on top of latest changes to review properly.

@makmanalp

Copy link
Copy Markdown
Contributor

So the filtering works great as far as I can see, but there is some trouble with tooltips after the filter is removed, e.g in industry scatters:

scatter_legends_lag2

and another example with product ones where suddenly it behaves strangely after the filtering is removed:

scatter_legends_lag

It's almost like the filter remains for the tooltip/hover even after it's been removed and the other nodes are visible.


Also, we probably should call this out of scope for this ticket, but it'd be cool to make it obvious that the legend is clickable.

@makmanalp

Copy link
Copy Markdown
Contributor

Also, there is a build error that seems relevant (https://circleci.com/gh/cid-harvard/atlas-subnational-frontend/669): "TypeError: undefined is not an object (evaluating 'keyFilter.length')" when you go to the country profile.

@gregshap

Copy link
Copy Markdown
Collaborator

Good catch @makmanalp

One other small thing: when filtering the product space, its very hard to see the difference between the products that this place does vs does not do

}]
}]
});
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JShint complaining about a missing semicolon here

@makmanalp

Copy link
Copy Markdown
Contributor

So @romsson it's still the same trouble for me: after filtering by a category and removing the filter, the tooltip only shows for the previously filtered category (and starts becoming laggy but that's less of a concern right now).

E.g. see after I filter by chemicals and undo the filter, how the purple ones are the only ones that have tooltips:

scatter_legends_lag3

@QuinnLee

QuinnLee commented May 6, 2016

Copy link
Copy Markdown
Contributor

@makmanalp we should rebase these frequently so we don't loose the feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants