-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just kicking the tires and making a text correction to the School Yearbook page #60
Conversation
Signed-off-by: Akshay Mestry <[email protected]>
Reference: - #3 Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis: - GitHub Actions workflows break with both `paths` and `paths-ignore` are present in the workflow file. This change removes the latter fixing the issue. Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis: - For some reason, the JupyterLite patch failed on the CI checkout. This seems quite strange as on the all the local and SI testing, it did seem to work. But nonetheless, removed it for now to test the overall deployment process. Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis: - In all the internal testings, everything seemed to be quite right yet the JupyterLite seemed to cause some issues which are currently not yet identified to be resolved for a complete proof. - Hence, removing the inputs where JupyterLite was considered as important. This is by no means trying to put an end to the use of JupyterLite, we very much will investigate this further down the road but as of now, it seems not relevant. Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
…eadme docs: update README.rst with index content
Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis: - This change introduces smartly build sphinx documentation with minimal to no-code commands. The updated Makefile takes care of the documentation building. However, if the documentation building process needs extra arguments, they should fallback to the verbose `sphinx-build` method. - This change adds native support for sphinx-linting before every build, ensuring the code quality is maintained. Signed-off-by: Akshay Mestry <[email protected]>
Description: - This change adds support for accounts setup page. Although not fully finished, the page marks as a good starting point for further documentation and exploration. Signed-off-by: Akshay Mestry <[email protected]>
BREAKING CHANGE: - This change deprecates the use of linting workflow in favor of only deployment. This change doesn't compromises any functionality but merely simplifies the workflow. Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
…oyment-pipeline Keep only deployment workflow
Signed-off-by: Akshay Mestry <[email protected]>
…tutorial docs: update content with ORCID setup
Signed-off-by: Akshay Mestry <[email protected]>
Description of the commit: - This change introduces use of a custom bug report issue template. Signed-off-by: Akshay Mestry <[email protected]>
[CI] Change workflow trigger to targets
…hinx Docs/dhru contributing sphinx
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
…ributing-guide docs: remove water module archives
Signed-off-by: Akshay Mestry <[email protected]>
…aths ci: update the workflow path targets & PR template
Signed-off-by: Akshay Mestry <[email protected]>
docs: update authors
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
@kyttmacmanus, you may need to raise another PR with a different branch. This seems like a merge request into the main branch. I'm unable to see the changed files, shows the whole commit backlog of 3 months. |
Thanks Akshay, I was a bit confused about where the merge should go. Just
to make sure I understand, are you suggesting I create my own branch and
then create PR to merge into Canary? Please let me know and thanks for the
spoon-feeding.
…On Mon, Jan 13, 2025 at 3:14 PM XA ***@***.***> wrote:
@ kyttmacmanus, you may need to raise another PR with a different branch.
This seems like a merge request into the main branch. I'm unable to see the
changed files, shows the whole commit backlog of 3 months. — Reply to this
email directly,
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
@kyttmacmanus
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kyttmacmanus&d=DwMFaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=N5AsY4jLonqxJEJI_QvE6za7XaSQVdPOqklIVrvVUGM&m=w4hbvvnGGufLjC2WkHo7IRZmw2EGFxF_1H51TOq0aRyj_U2Xdn1YgXxA0spVkXSq&s=HOTmYVqj9X-t7BfH6HRRv45W2MXcDPvvNQGoIzMrJgg&e=>,
you may need to raise another PR with a different branch. This seems like a
merge request into the main branch. I'm unable to see the changed files,
shows the whole commit backlog of 3 months.
—
Reply to this email directly, view it on GitHub
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ciesin-2Dgeospatial_TOPSTSCHOOL-2DSPHINX_pull_60-23issuecomment-2D2588102044&d=DwMFaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=N5AsY4jLonqxJEJI_QvE6za7XaSQVdPOqklIVrvVUGM&m=w4hbvvnGGufLjC2WkHo7IRZmw2EGFxF_1H51TOq0aRyj_U2Xdn1YgXxA0spVkXSq&s=zYtWtYZlvOi8nQTGgyTqnrAw-I2GwOvLpyJdP5i8MXc&e=>,
or unsubscribe
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABCA5YBRQFIMQ6Q65QIJQ2T2KQNBXAVCNFSM6AAAAABVC7LH6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBYGEYDEMBUGQ&d=DwMFaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=N5AsY4jLonqxJEJI_QvE6za7XaSQVdPOqklIVrvVUGM&m=w4hbvvnGGufLjC2WkHo7IRZmw2EGFxF_1H51TOq0aRyj_U2Xdn1YgXxA0spVkXSq&s=Gvdmx4JNtrzEOiDFNdZcuJxo5dJc0mPEmbqM8BdjQrs&e=>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Kytt MacManus (he/him)
Applied Science Lead, Environmental Flow Physics Lab (
https://efpl.engineering.columbia.edu/)
Columbia University School of Engineering and Applied Science
Civil Engineering & Engineering Mechanics Department
Adjunct Lecturer, E3B Dept of Columbia College
|
yes, you need to first fork the repository else git will you an error when you submit your changes. Once you fork the repository in your account, you can checkout your branch using command |
Fixed photos for Hieu Tran and Albers Sanchez 2nd attempt
Sorry for the delay, I just followed the described workflow and tried again. Please let me know if it looks good? |
closing this one as it is merged in #61 |
Thank you for your contribution!
To help us understand and review your changes quickly, please complete the checklist and provide all relevant details.
Brief Summary
Corrects photos for Hieu Tran and Alber Sanchez
Type of Change
Please select the type of change your pull request introduces: