Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just kicking the tires and making a text correction to the School Yearbook page #60

Closed
wants to merge 83 commits into from

Conversation

kyttmacmanus
Copy link
Collaborator

@kyttmacmanus kyttmacmanus commented Jan 13, 2025

Thank you for your contribution!
To help us understand and review your changes quickly, please complete the checklist and provide all relevant details.

Brief Summary

Corrects photos for Hieu Tran and Alber Sanchez

Type of Change

Please select the type of change your pull request introduces:

  • [ X] Bug fix (fixes an issue)
  • New feature (adds functionality)
  • Documentation update (improves or adds documentation)
  • Code style/refactor (improves the code structure, does not add functionality)
  • Configuration change (modifies settings or configurations)
  • Build/dependency update (changes build or dependencies)

xames3 added 30 commits October 31, 2024 00:36
Reference:
  - #3

Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis:
    - GitHub Actions workflows break with both `paths` and `paths-ignore`
      are present in the workflow file. This change removes the latter
      fixing the issue.

Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis:
    - For some reason, the JupyterLite patch failed on the CI checkout.
      This seems quite strange as on the all the local and SI testing,
      it did seem to work. But nonetheless, removed it for now to test
      the overall deployment process.

Signed-off-by: Akshay Mestry <[email protected]>
Impact Analysis:
    - In all the internal testings, everything seemed to be quite right
      yet the JupyterLite seemed to cause some issues which are
      currently not yet identified to be resolved for a complete proof.
    - Hence, removing the inputs where JupyterLite was considered as
      important. This is by no means trying to put an end to the use of
      JupyterLite, we very much will investigate this further down the
      road but as of now, it seems not relevant.

Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
…eadme

docs: update README.rst with index content
Impact Analysis:
    - This change introduces smartly build sphinx documentation with
      minimal to no-code commands. The updated Makefile takes care of the
      documentation building. However, if the documentation building
      process needs extra arguments, they should fallback to the verbose
      `sphinx-build` method.
    - This change adds native support for sphinx-linting before every
      build, ensuring the code quality is maintained.

Signed-off-by: Akshay Mestry <[email protected]>
Description:
    - This change adds support for accounts setup page. Although not
      fully finished, the page marks as a good starting point for further
      documentation and exploration.

Signed-off-by: Akshay Mestry <[email protected]>
BREAKING CHANGE:
    - This change deprecates the use of linting workflow in favor of
      only deployment. This change doesn't compromises any functionality
      but merely simplifies the workflow.

Signed-off-by: Akshay Mestry <[email protected]>
…oyment-pipeline

Keep only deployment workflow
…tutorial

docs: update content with ORCID setup
Description of the commit:
    - This change introduces use of a custom bug report issue template.

Signed-off-by: Akshay Mestry <[email protected]>
xames3 and others added 21 commits November 28, 2024 20:35
Signed-off-by: Akshay Mestry <[email protected]>
…ributing-guide

docs: remove water module archives
…aths

ci: update the workflow path targets & PR template
Signed-off-by: Akshay Mestry <[email protected]>
Signed-off-by: Akshay Mestry <[email protected]>
@kyttmacmanus kyttmacmanus requested a review from xames3 January 13, 2025 19:50
@xames3
Copy link
Collaborator

xames3 commented Jan 13, 2025

@kyttmacmanus, you may need to raise another PR with a different branch. This seems like a merge request into the main branch. I'm unable to see the changed files, shows the whole commit backlog of 3 months.

@kyttmacmanus
Copy link
Collaborator Author

kyttmacmanus commented Jan 13, 2025 via email

@xames3
Copy link
Collaborator

xames3 commented Jan 14, 2025

yes, you need to first fork the repository else git will you an error when you submit your changes. Once you fork the repository in your account, you can checkout your branch using command git checkout -b docs/kytt-latest. This will create your branch (docs/kytt-latest) and you can edit your changes in it and push it. Once that’s done, raise a PR to merge with canary and we can then merge it here. Hope that helps. I can help if you need any more information.

Fixed photos for Hieu Tran and Albers Sanchez 2nd attempt
@kyttmacmanus
Copy link
Collaborator Author

Sorry for the delay, I just followed the described workflow and tried again. Please let me know if it looks good?

@xames3
Copy link
Collaborator

xames3 commented Jan 28, 2025

closing this one as it is merged in #61

@xames3 xames3 closed this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants