Skip to content

upgraded dependencies, moved numpy to 2.1.0 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hstarmans
Copy link

@hstarmans hstarmans commented Oct 7, 2024

Fixes Issue #166.

This PR addresses move to numpy 2.1.0.
Pytest results are consistent with previous runs, with most tests passing.
Pyoptools is added to Freecad by first creating a wheel and then installing this wheel

python -m build --wheel
// using python exe from freecad
 ./python.exe -m pip install pyoptools-0.1.2.dev204+g8330d08-cp311-cp311-win_amd64.whl

I use pyoptools to verify the position of optical components of my laser scanner, hexastorm.com.

What I would recommend:

  • dispatch some of the code through an LLM, I still get warnings when running (python setup.py build_ext --inplace)
  • consider using a build system like poetry or uv. UV is faster but documentation and functionality are not on par with poetry

@ramezquitao
Copy link
Member

ramezquitao commented Oct 7, 2024

@hstarmans, thank you for your help. I’ll review your proposal. I just wanted to let you know that I've been working on removing the compiled dependencies for NumPy, which has caused several issues, particularly when using pyOpTools in FreeCAD 1.0. A lot of refactoring has happened in the process, and most of the NumPy dependencies in the raytrace module have been removed. I'm currently testing a local version and expect to merge these changes by the end of the week. After that, I’ll focus on merging your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants