fix: rhdh start up crash when notification plugin is enabled??? #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin (redhat-developer#1944) * refactor(homepage): remove internal dynamic-home-page plugin Signed-off-by: Christoph Jerolimov <[email protected]> * refactor(homepage): add wrapper for rhdh plugin Signed-off-by: Christoph Jerolimov <[email protected]> --------- Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
* feat: add monorepo tools to check dependencies Signed-off-by: Paul Schultz <[email protected]> * fix tsc issue Signed-off-by: Paul Schultz <[email protected]> * fix wrappers Signed-off-by: Paul Schultz <[email protected]> * mend --------- Signed-off-by: Paul Schultz <[email protected]>
Signed-off-by: Nick Boldt <[email protected]>
…edhat-developer#1997) Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Jessica He <[email protected]> Co-authored-by: Kim Tsao <[email protected]>
Signed-off-by: Kim Tsao <[email protected]>
…ns in playwright tests (redhat-developer#2003) * fix(rbac): add support for mui v5 buttons in e2e helper Signed-off-by: Christoph Jerolimov <[email protected]> * chore(ci): disable `droute` until outage is resolved * fix(e2e): skip broken/flaky tests Signed-off-by: Christoph Jerolimov <[email protected]> --------- Signed-off-by: Christoph Jerolimov <[email protected]> Co-authored-by: Zbyněk Drápela <[email protected]>
* style more like * add anotation about running on CI * expanding and grouping developer guidelines * add paths ignore for e2e docs * adding Use of External Sources for Validation * reorganization * delete innecessari duplications of principles for new PRs * move e2e contributing file * delete duplicates * +readme.md * improve e2e lint * enforce naming * enforce case with lint * fix broken waitForNextSync * add prettier and lint check for e2e * fix missing lint errors * fix problem caused on github-helper * rename catalog * wip * delete logger * + logger * update for catalog path * rename logs again * fix lint check on CI * + POM * wip on RbacPo * wip * wip wip wip replace old references with rbacPo * amenda * adjust kubeclient naming and usage * wip * fix merge conflicts * rename typo on KubeClient * wip * wip * fix lint * fix tests * minor fixes * fix main conflicts * ignore any for lint --------- Co-authored-by: Joseph Kim <[email protected]>
…1993) Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: Christoph Jerolimov <[email protected]>
…per#1980) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…gin and E2E scenario (redhat-developer#1695) * [Test automation] Verify Topology is a supported plugin and E2E scenario * PR QOL changes * Fixed conflict * Lint fix
…8 to 0.9) (redhat-developer#1969) Signed-off-by: Christoph Jerolimov <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…li (redhat-developer#2040) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: janus-idp[bot] <139477802+janus-idp[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: janus-idp[bot] <139477802+janus-idp[bot]@users.noreply.github.com>
…per#2026) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Christoph Jerolimov <[email protected]>
…gin (redhat-developer#2024) Signed-off-by: Christoph Jerolimov <[email protected]>
* enable auth providers for nightly jobs * enable auth providers for nightly jobs * enable auth providers for nightly jobs * enable auth providers for nightly jobs * enable auth providers for nightly jobs * fix error * fix error * fix error * fixes * fix helm delete * fix login timeout * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix timeouts * fix gh test * add config for nightly job * fix lint errors * fix lint errors
* chore: update rbac plugins * chore(e2e): close out dropdown after selecting rbac users and groups * chore(e2e): heading changes for the rbac plugin * chore: bump rbac plugins to latest * chore(e2e): update input placeholder from filter to search
…oper#2330) * chore(deps): use some plugins updated to backstage 1.35 Use plugins updated to backstage 1.35: @backstage-community/scaffolder-backend-module-regex 2.4.0 @backstage-community/[email protected] @backstage-community/[email protected] @backstage-community/[email protected] @backstage-community/[email protected] @backstage-community/[email protected] @backstage-community/plugin-catalog-backend-module-scaffolder-relation-processor@2.2.0 Signed-off-by: Oleksandr Andriienko <[email protected]> * feat(rbac): update more plugins Update: @backstage-community/plugin-catalog-backend-module-keycloak 3.5.0 @backstage-community/plugin-jfrog-artifactory: 1.12.0 @backstage-community/plugin-nexus-repository-manager: 1.11.0 @backstage-community/plugin-ocm: 5.3.0 @backstage-community/plugin-ocm-backend: 5.3.0 @backstage-community/plugin-scaffolder-backend-module-servicenow 2.4.0 Signed-off-by: Oleksandr Andriienko <[email protected]> --------- Signed-off-by: Oleksandr Andriienko <[email protected]>
…edhat-developer#2362) Signed-off-by: Nick Boldt <[email protected]>
Signed-off-by: Jessica He <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(e2e): fix rbac `users, groups` with regex * Use function and generalize * Add regexp for longer version * Better functions * Use filter instead * use `aria-label` instead of `placeholder` * Two search options by Placeholder and AriaLabel
* chore(e2e): fix k8s specific config * Use k8s config for all * Discard useCommonDeviceAndViewportConfig * Progressively increase timeouts * Fix if multiple ingresses * Omit smoke-test from main tests * Fix pre first * Use safer dispatchEvent click * Remove redundant hardcoded timeouts so they can be overridden by project settings
…per#2386) Signed-off-by: Kim Tsao <[email protected]>
…eloper#2388) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…oper#2394) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…oper#2377) * fix(sidebar): added config for default search menu item * fix(sidebar): added config to disable search, logo, settings and administration menu items * fix(sidebar): added config to disable search, logo, settings and administration menu items * fix(sidebar): added config to disable search, logo, settings and administration menu items
…tag to v9.5-1739783265 (redhat-developer#2398) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update basic-authentication.spec.ts * Update github-provider.spec.ts * Update microsoft-provider.spec.ts
redhat-developer#2248) * Add temporary plugin configurations for sandbox setup * Add sanity plugins check to pipeline scripts and tests Signed-off-by: Gustavo Lira <[email protected]> * Remove default JOB_NAME export from CI test script Signed-off-by: Gustavo Lira <[email protected]> * Add audit log tests and remove commented-out config Signed-off-by: Gustavo Lira <[email protected]> * Refactor periodic sanity plugin checks deployment logic Moved plugin checks deployment logic to a reusable function `initiate_sanity_plugin_checks_deployment`. Simplified the `run_sanity_plugins_check` method by delegating complex deployment steps to the new function, improving readability and maintainability. Signed-off-by: Gustavo Lira <[email protected]> --------- Signed-off-by: Gustavo Lira <[email protected]>
…redhat-developer#2390) Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…at-developer#2383) * Update audit log messages for e2e tests. Signed-off-by: Gustavo Lira <[email protected]> * Refactor audit log tests to improve readability Signed-off-by: Gustavo Lira <[email protected]> * Update e2e test for scaffolder logs and streamline validations Signed-off-by: Gustavo Lira <[email protected]> * Update e2e test for scaffolder logs and streamline validations Signed-off-by: Gustavo Lira <[email protected]> * Add "Queued" status to security scan regex Signed-off-by: Gustavo Lira <[email protected]> * Refactor regex formatting in Quay utility function. Signed-off-by: Gustavo Lira <[email protected]> * Enhance clickById method with wait for attached state. Updated the clickById method to ensure the element is attached before attempting a click. This improves reliability by ensuring the element is present in the DOM when interacting with it. Signed-off-by: Gustavo Lira <[email protected]> * Update regex to include Medium and Low security scan statuses Signed-off-by: Gustavo Lira <[email protected]> * Simplify security scan test logic in Quay spec. Removed conditional checks and unnecessary branching in the "Check Security Scan details" test. The new implementation directly verifies the scan cells in the table. Signed-off-by: Gustavo Lira <[email protected]> * Simplified the argument structure in the `verifyCellsInTable` function call by removing unnecessary line breaks. Signed-off-by: Gustavo Lira <[email protected]> * Update Quay security scan test to use visibility check Signed-off-by: Gustavo Lira <[email protected]> * Update Quay security scan test to use visibility check Signed-off-by: Gustavo Lira <[email protected]> --------- Signed-off-by: Gustavo Lira <[email protected]>
…at-developer#2263) * feat(global-header): added config for default header components Signed-off-by: Yi Cai <[email protected]> * prettier fix Signed-off-by: Yi Cai <[email protected]> * hide header items in sidebar Signed-off-by: Yi Cai <[email protected]> * resolve failed ci checks Signed-off-by: Yi Cai <[email protected]> * resolve failed ci checks Signed-off-by: Yi Cai <[email protected]> * updated header component mp name Signed-off-by: Yi Cai <[email protected]> * added icons and updated global header config Signed-off-by: Yi Cai <[email protected]> * addressed review comments Signed-off-by: Yi Cai <[email protected]> * updated global header wrapper to take the latest release Signed-off-by: Yi Cai <[email protected]> * removed default support button url Signed-off-by: Yi Cai <[email protected]> * resolved merging conflicts Signed-off-by: Yi Cai <[email protected]> * addressed review comments Signed-off-by: Yi Cai <[email protected]> * updated theme package to pick up changes for global header Signed-off-by: Yi Cai <[email protected]> * fix: align application header mountpoint with other mount points Signed-off-by: Christoph Jerolimov <[email protected]> * fixed double scrollbar issue Signed-off-by: Yi Cai <[email protected]> * small pickup Signed-off-by: Yi Cai <[email protected]> * prettier fix Signed-off-by: Yi Cai <[email protected]> * updated default global header config Signed-off-by: Yi Cai <[email protected]> * fixed global header version Signed-off-by: Yi Cai <[email protected]> * fixed default global header config Signed-off-by: Yi Cai <[email protected]> * updated header package.json dependency Signed-off-by: Yi Cai <[email protected]> * ignore the problematic link Signed-off-by: Yi Cai <[email protected]> * updated yarn.lock Signed-off-by: Yi Cai <[email protected]> * code clean Signed-off-by: Yi Cai <[email protected]> * code clean Signed-off-by: Yi Cai <[email protected]> * added config to hide search and settings when header is enabled Signed-off-by: Yi Cai <[email protected]> * feat(global-header): use global-header 1.0.0 * feat(global-header): add optional layout config option for the header itself * docs(global-header): small fix * feat(global-header): enable new global-header plugin by default * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * chore(global-header): disable header in e2e tests for now * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * fix(global-header): fix duplicate scrollbar issues (incl. RHIDP-4637) * hide notifications from sidebar by default Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> Signed-off-by: Christoph Jerolimov <[email protected]> Co-authored-by: Christoph Jerolimov <[email protected]>
* fix: replace a dead link with a valid one Signed-off-by: Yi Cai <[email protected]> * replace hardcoded version with latest Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
This reverts commit 90b2893.
ciiay
pushed a commit
that referenced
this pull request
Nov 17, 2025
* fix(auto-approve): add checkout step to fix 'not a git repository' error The gh CLI commands were failing because the repository wasn't checked out. Added actions/checkout@v4 step to ensure git context is available. * test: temporarily enable workflow for polasudo to test functionality * test: add fix/auto-approve-bot to eligible patterns for testing * fix(auto-approve): add issues:write permission for label management * fix(auto-approve): use pull_request_target for proper permissions Using pull_request_target instead of pull_request allows the workflow to run with write permissions even for PRs from forks or bot accounts. This is necessary for adding labels and approving PRs. * Fix auto-approve workflow: use REST API for adding labels instead of gh CLI * test: trigger workflow re-run * test: remove trigger file * test: temporarily disable user condition to test workflow * fix(auto-approve): use pull_request_target and add issues:write permission - Change trigger from pull_request to pull_request_target for proper permissions - Add issues:write permission required for label management - Add --repo flag to gh commands for explicit repository context - Remove checkout step (not needed with pull_request_target) - Fixes GraphQL: Resource not accessible by integration error * fix(auto-approve): add fix/auto-approve-bot pattern for testing * feat(auto-approve): add push trigger for faster testing feedback - Add push trigger on fix/auto-approve-bot branch for immediate testing - Handle both push and pull_request_target events in workflow logic - Add logging step for push events to show eligibility check results - Only run label/approve actions on actual PR events * test: trigger workflow rerun * test: simplify push logging to debug workflow triggering * test: add temporary PR labeling simulation for fork testing * test: enable real PR labeling on push events for testing * test: target PR #1 in fork for labeling test * test: target PR #2 for labeling demonstration * feat: clean up auto-approve workflow for production use - Remove all testing code (push triggers, test PR numbers, debug logging) - Simplify workflow to only run on pull_request_target events - Only run for rhdh-bot PRs - Keep fix/auto-approve-bot pattern for final testing before merge - Ready for production deployment * test: temporarily allow polasudo for final workflow testing * feat: finalize auto-approve workflow for production - Remove temporary polasudo testing allowance - Remove fix/auto-approve-bot test pattern - Clean, production-ready workflow for rhdh-bot PRs - Ready to merge and deploy * test: trigger workflow to demonstrate PR #2 labeling * Delete test-workflow-final.md * chore: reorganize auto-approve workflow flags for better readability
ciiay
pushed a commit
that referenced
this pull request
Nov 25, 2025
…eveloper#3717) * fix(auto-approve): add checkout step to fix 'not a git repository' error The gh CLI commands were failing because the repository wasn't checked out. Added actions/checkout@v4 step to ensure git context is available. * test: temporarily enable workflow for polasudo to test functionality * test: add fix/auto-approve-bot to eligible patterns for testing * fix(auto-approve): add issues:write permission for label management * fix(auto-approve): use pull_request_target for proper permissions Using pull_request_target instead of pull_request allows the workflow to run with write permissions even for PRs from forks or bot accounts. This is necessary for adding labels and approving PRs. * Fix auto-approve workflow: use REST API for adding labels instead of gh CLI * test: trigger workflow re-run * test: remove trigger file * test: temporarily disable user condition to test workflow * fix(auto-approve): use pull_request_target and add issues:write permission - Change trigger from pull_request to pull_request_target for proper permissions - Add issues:write permission required for label management - Add --repo flag to gh commands for explicit repository context - Remove checkout step (not needed with pull_request_target) - Fixes GraphQL: Resource not accessible by integration error * fix(auto-approve): add fix/auto-approve-bot pattern for testing * feat(auto-approve): add push trigger for faster testing feedback - Add push trigger on fix/auto-approve-bot branch for immediate testing - Handle both push and pull_request_target events in workflow logic - Add logging step for push events to show eligibility check results - Only run label/approve actions on actual PR events * test: trigger workflow rerun * test: simplify push logging to debug workflow triggering * test: add temporary PR labeling simulation for fork testing * test: enable real PR labeling on push events for testing * test: target PR #1 in fork for labeling test * test: target PR #2 for labeling demonstration * feat: clean up auto-approve workflow for production use - Remove all testing code (push triggers, test PR numbers, debug logging) - Simplify workflow to only run on pull_request_target events - Only run for rhdh-bot PRs - Keep fix/auto-approve-bot pattern for final testing before merge - Ready for production deployment * test: temporarily allow polasudo for final workflow testing * feat: finalize auto-approve workflow for production - Remove temporary polasudo testing allowance - Remove fix/auto-approve-bot test pattern - Clean, production-ready workflow for rhdh-bot PRs - Ready to merge and deploy * test: trigger workflow to demonstrate PR #2 labeling * Delete test-workflow-final.md * chore: reorganize auto-approve workflow flags for better readability * fix(ci): add checkout step to auto-approve-bot-prs workflow to fix git repository error - Adds actions/checkout@v4 to provide git context for gh CLI commands - Fixes 'fatal: not a git repository' error in auto-approve workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer