Skip to content

Conversation

@its-mitesh-kumar
Copy link

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@ciiay ciiay force-pushed the rhidp-6170-add-marketplace-install-page branch 2 times, most recently from 1594c8a to 6fcd39d Compare April 7, 2025 15:29
@its-mitesh-kumar
Copy link
Author

Closing this PR since It has been included in PR-2625

ciiay pushed a commit that referenced this pull request Nov 17, 2025
* fix(auto-approve): add checkout step to fix 'not a git repository' error

The gh CLI commands were failing because the repository wasn't checked out.
Added actions/checkout@v4 step to ensure git context is available.

* test: temporarily enable workflow for polasudo to test functionality

* test: add fix/auto-approve-bot to eligible patterns for testing

* fix(auto-approve): add issues:write permission for label management

* fix(auto-approve): use pull_request_target for proper permissions

Using pull_request_target instead of pull_request allows the workflow
to run with write permissions even for PRs from forks or bot accounts.
This is necessary for adding labels and approving PRs.

* Fix auto-approve workflow: use REST API for adding labels instead of gh CLI

* test: trigger workflow re-run

* test: remove trigger file

* test: temporarily disable user condition to test workflow

* fix(auto-approve): use pull_request_target and add issues:write permission

- Change trigger from pull_request to pull_request_target for proper permissions
- Add issues:write permission required for label management
- Add --repo flag to gh commands for explicit repository context
- Remove checkout step (not needed with pull_request_target)
- Fixes GraphQL: Resource not accessible by integration error

* fix(auto-approve): add fix/auto-approve-bot pattern for testing

* feat(auto-approve): add push trigger for faster testing feedback

- Add push trigger on fix/auto-approve-bot branch for immediate testing
- Handle both push and pull_request_target events in workflow logic
- Add logging step for push events to show eligibility check results
- Only run label/approve actions on actual PR events

* test: trigger workflow rerun

* test: simplify push logging to debug workflow triggering

* test: add temporary PR labeling simulation for fork testing

* test: enable real PR labeling on push events for testing

* test: target PR #1 in fork for labeling test

* test: target PR #2 for labeling demonstration

* feat: clean up auto-approve workflow for production use

- Remove all testing code (push triggers, test PR numbers, debug logging)
- Simplify workflow to only run on pull_request_target events
- Only run for rhdh-bot PRs
- Keep fix/auto-approve-bot pattern for final testing before merge
- Ready for production deployment

* test: temporarily allow polasudo for final workflow testing

* feat: finalize auto-approve workflow for production

- Remove temporary polasudo testing allowance
- Remove fix/auto-approve-bot test pattern
- Clean, production-ready workflow for rhdh-bot PRs
- Ready to merge and deploy

* test: trigger workflow to demonstrate PR #2 labeling

* Delete test-workflow-final.md

* chore: reorganize auto-approve workflow flags for better readability
ciiay pushed a commit that referenced this pull request Nov 25, 2025
…eveloper#3717)

* fix(auto-approve): add checkout step to fix 'not a git repository' error

The gh CLI commands were failing because the repository wasn't checked out.
Added actions/checkout@v4 step to ensure git context is available.

* test: temporarily enable workflow for polasudo to test functionality

* test: add fix/auto-approve-bot to eligible patterns for testing

* fix(auto-approve): add issues:write permission for label management

* fix(auto-approve): use pull_request_target for proper permissions

Using pull_request_target instead of pull_request allows the workflow
to run with write permissions even for PRs from forks or bot accounts.
This is necessary for adding labels and approving PRs.

* Fix auto-approve workflow: use REST API for adding labels instead of gh CLI

* test: trigger workflow re-run

* test: remove trigger file

* test: temporarily disable user condition to test workflow

* fix(auto-approve): use pull_request_target and add issues:write permission

- Change trigger from pull_request to pull_request_target for proper permissions
- Add issues:write permission required for label management
- Add --repo flag to gh commands for explicit repository context
- Remove checkout step (not needed with pull_request_target)
- Fixes GraphQL: Resource not accessible by integration error

* fix(auto-approve): add fix/auto-approve-bot pattern for testing

* feat(auto-approve): add push trigger for faster testing feedback

- Add push trigger on fix/auto-approve-bot branch for immediate testing
- Handle both push and pull_request_target events in workflow logic
- Add logging step for push events to show eligibility check results
- Only run label/approve actions on actual PR events

* test: trigger workflow rerun

* test: simplify push logging to debug workflow triggering

* test: add temporary PR labeling simulation for fork testing

* test: enable real PR labeling on push events for testing

* test: target PR #1 in fork for labeling test

* test: target PR #2 for labeling demonstration

* feat: clean up auto-approve workflow for production use

- Remove all testing code (push triggers, test PR numbers, debug logging)
- Simplify workflow to only run on pull_request_target events
- Only run for rhdh-bot PRs
- Keep fix/auto-approve-bot pattern for final testing before merge
- Ready for production deployment

* test: temporarily allow polasudo for final workflow testing

* feat: finalize auto-approve workflow for production

- Remove temporary polasudo testing allowance
- Remove fix/auto-approve-bot test pattern
- Clean, production-ready workflow for rhdh-bot PRs
- Ready to merge and deploy

* test: trigger workflow to demonstrate PR #2 labeling

* Delete test-workflow-final.md

* chore: reorganize auto-approve workflow flags for better readability

* fix(ci): add checkout step to auto-approve-bot-prs workflow to fix git repository error

- Adds actions/checkout@v4 to provide git context for gh CLI commands
- Fixes 'fatal: not a git repository' error in auto-approve workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants