socket_option: Change policy_resolver_ to a weak pointer #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shared_ptr policy_resolver_ holds on to the passed BpfMetadata::Config, which owns the policy map reference. This could keep the the policy map alive when the listeners are destructed, leading to the destruction of the policy map from a worker thread. Change policy_resolver_ to a weak pointer to resolve this. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
weak-policy-resolver
branch
from
c205cb9 to
db5321a
Compare
sayboras
approved these changes
Dec 1, 2024
sayboras
added a commit
to cilium/cilium
that referenced
this pull request
Dec 2, 2024
Main goal is to include the below fix. Relates: cilium/proxy#1016 Signed-off-by: Tam Mach <[email protected]>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 2, 2024
Main goal is to include the below fix. Relates: cilium/proxy#1016 Signed-off-by: Tam Mach <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 2, 2024
Main goal is to include the below fix. Relates: cilium/proxy#1016 Signed-off-by: Tam Mach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shared_ptr policy_resolver_ holds on to the passed BpfMetadata::Config, which owns the policy map reference. This could keep the the policy map alive when the listeners are destructed, leading to the destruction of the policy map from a worker thread. Change policy_resolver_ to a weak pointer to resolve this.