-
-
Notifications
You must be signed in to change notification settings - Fork 80
Add support for building release images with debug information #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nezdolik
reviewed
Nov 17, 2025
968a29d to
427fea8
Compare
3ace253 to
4bd60ac
Compare
407aa9b to
83ae831
Compare
Member
|
any reason to do it with 1.34 branch first ? Normally, we do the changes for main and then backport to older stable branch instead. |
Contributor
Author
Because that's where we needed it for our perf tests :) |
83ae831 to
cc79648
Compare
nezdolik
approved these changes
Dec 3, 2025
cc79648 to
f9dc84e
Compare
This woula allow calling `bazel build` with `--configure=release_debug`. The resulting binary will retain all the symbols information. It also is big, around 2GB. Signed-off-by: Nikolay Nikolaev <[email protected]>
We're passing this to the Makefile and then also in the Dockerfile. The result is calling the `bazel build --configure=release_debug` Signed-off-by: Nikolay Nikolaev <[email protected]>
We move the common image release workflow to a shareadble YAML and parametrize it. Then we include it in a release and release-debug YAML files. Signed-off-by: Nikolay Nikolaev <[email protected]>
f9dc84e to
6e4c4cd
Compare
sayboras
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bazel and make infrastructure to build release images with included symbols information.
It would be useful in production environments when debugging issues.
To leverage the build with CI, we move the core Release build functionality to
build-envoy-images-release-base.yamland then include it in the two new files:build-envoy-images-release.yaml- invoked on push in the branchbuild-envoy-images-release-debug.yaml- invoked on demand in the Actions UI