-
Notifications
You must be signed in to change notification settings - Fork 496
tetra: Fix tetra debug progs fail #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi:
Lines 163 to 169 in e4f084f
| if strings.HasSuffix(path, "link") { | |
| return nil // skip BPF links, they make the syscall fail since cilium/ebpf@78074c59 | |
| } | |
| prog, err := ebpf.LoadPinnedProgram(path, nil) | |
| if err != nil { | |
| return fmt.Errorf("failed to load pinned object %q: %w", path, err) | |
| } |
Commit: ca9aaa0
|
Also added in the meantime, something we could actually use to do thing properly cilium/ebpf#1626. |
8954c06 to
0b460c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments. Let me know what you think.
Thanks!
0b460c2 to
3353369
Compare
Recent ebpf changes make ebpf.LoadPinnedProgram fail on opening link path. We want to open only programs, so failing on opening links/maps is fine ad we just want to continue scanning. Enforcing leading '/' and adding '/link_override' suffix. Fixes: #3234 Signed-off-by: Jiri Olsa <[email protected]>
3353369 to
4949aba
Compare
kkourt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
4949aba to
4db3ec2
Compare
Adding support to detect bpffs mount so we don't need to specify --bpf-dir when running on top of k8s. Signed-off-by: Jiri Olsa <[email protected]>
Adding support to detect lib directory so we don't need to specify --bpf-lib when running on top of k8s. Signed-off-by: Jiri Olsa <[email protected]>
Detect available terminal lines and print only output that fits on terminal. This is enabled only when in periodical output with cleared screen. Signed-off-by: Jiri Olsa <[email protected]>
With the new auto detect values. Signed-off-by: Jiri Olsa <[email protected]>
4db3ec2 to
4c1dd17
Compare
Recent ebpf changes make ebpf.LoadPinnedProgram fail on opening link path. We want to open only programs, so failing on opening links/maps is fine ad we just want to continue scanning.
Fixes: #3234