Skip to content

tetragon/windows: Build windows bpf program and smoke test tetragon #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ExceptionalHandler
Copy link
Contributor

@ExceptionalHandler ExceptionalHandler commented Apr 16, 2025

Description

This CI action does the following actions:

  1. Build the process_monitor.sys bpf program and the ntosebpfext.sys driver it depends on. These programs are uploaded as artifacts.
  2. Build tetragon.exe and tetra,exe on a Windows worker and uploads them as artifacts.
  3. Downloads the artifacts and installs them, downloads the ebpf-for-windows build and installs it. Runs tetragon.exe and launches a process to see if an event is received.

@ExceptionalHandler ExceptionalHandler force-pushed the v/ci/windows/prog branch 8 times, most recently from cc917a3 to 55d3fac Compare April 16, 2025 23:41
@ExceptionalHandler ExceptionalHandler added the release-note/ci This PR makes changes to the CI. label Apr 16, 2025
@ExceptionalHandler ExceptionalHandler force-pushed the v/ci/windows/prog branch 2 times, most recently from e211de6 to 5d6e8dc Compare April 18, 2025 21:49
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 5d6e8dc
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6802c8eab2ac5600083cdc18
😎 Deploy Preview https://deploy-preview-3645--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ExceptionalHandler ExceptionalHandler force-pushed the v/ci/windows/prog branch 18 times, most recently from 9ec0cac to a64d381 Compare April 22, 2025 01:32
@ExceptionalHandler ExceptionalHandler force-pushed the v/ci/windows/prog branch 11 times, most recently from c12b0ee to 07c6250 Compare April 23, 2025 01:32
@ExceptionalHandler ExceptionalHandler marked this pull request as ready for review April 23, 2025 01:32
@ExceptionalHandler ExceptionalHandler requested a review from a team as a code owner April 23, 2025 01:32
@ExceptionalHandler ExceptionalHandler changed the title tetragon/windows: Build windows bpf program tetragon/windows: Build windows bpf program and smoke test tetragon Apr 23, 2025
@ExceptionalHandler ExceptionalHandler force-pushed the v/ci/windows/prog branch 2 times, most recently from ea8e3aa to 165199c Compare April 23, 2025 01:54
Copy link
Contributor

@kevsecurity kevsecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe ask @will-isovalent or @mtardy to take a look too.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay, I would maybe just tidy the random whitespace/empty lines to make it look more readable, remove the unused strategy matrix and the unused if statements?

Comment on lines 17 to 20
strategy:
matrix:
version:
- main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you never use the strategy matrix in your job, you specify it 3 times without using it.

Suggested change
strategy:
matrix:
version:
- main

Comment on lines 104 to 123
strategy:
matrix:
version:
- main

env:
TEMP: D:\temp


steps:

- run: mkdir D:\temp
shell: pwsh

- name: Install Go
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
with:
go-version: '1.24.2'


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spaces look off

path: ${{ env.TEMP }}\Tetragon-Windows.zip
retention-days: 5

windows-Smoke-test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: random uppercase seems to be a Windows thing lol

Suggested change
windows-Smoke-test:
windows-smoke-test:

msbuild-architecture: x64

- name: Add Visual Studio LLVM to path
if: steps.skip_check.outputs.should_skip != 'true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step doesn't exists it seems, so this will never be triggered in all the following steps

This CI action does the following actions:

Build the process_monitor.sys bpf program and the ntosebpfext.sys driver it depends on. These programs are uploaded as artifacts.

Build tetragon.exe and tetra,exe on a Windows worker and uploads them asartifacts.

Downloads the artifacts and installs them. A file setup-windows.ps1 is added to facilitate this step.

It then downloads the ebpf-for-windows build and installs it. Runs tetragon.exe and launches a process to see if an event is received.

Signed-off-by: Anadi Anadi <[email protected]>
@ExceptionalHandler ExceptionalHandler merged commit 6a15558 into cilium:main Apr 23, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants