-
Notifications
You must be signed in to change notification settings - Fork 409
tetragon/windows: Build windows bpf program and smoke test tetragon #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon/windows: Build windows bpf program and smoke test tetragon #3645
Conversation
cc917a3
to
55d3fac
Compare
e211de6
to
5d6e8dc
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9ec0cac
to
a64d381
Compare
c12b0ee
to
07c6250
Compare
ea8e3aa
to
165199c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but maybe ask @will-isovalent or @mtardy to take a look too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay, I would maybe just tidy the random whitespace/empty lines to make it look more readable, remove the unused strategy matrix and the unused if
statements?
strategy: | ||
matrix: | ||
version: | ||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems you never use the strategy matrix in your job, you specify it 3 times without using it.
strategy: | |
matrix: | |
version: | |
- main |
strategy: | ||
matrix: | ||
version: | ||
- main | ||
|
||
env: | ||
TEMP: D:\temp | ||
|
||
|
||
steps: | ||
|
||
- run: mkdir D:\temp | ||
shell: pwsh | ||
|
||
- name: Install Go | ||
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0 | ||
with: | ||
go-version: '1.24.2' | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: spaces look off
path: ${{ env.TEMP }}\Tetragon-Windows.zip | ||
retention-days: 5 | ||
|
||
windows-Smoke-test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: random uppercase seems to be a Windows thing lol
windows-Smoke-test: | |
windows-smoke-test: |
msbuild-architecture: x64 | ||
|
||
- name: Add Visual Studio LLVM to path | ||
if: steps.skip_check.outputs.should_skip != 'true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step doesn't exists it seems, so this will never be triggered in all the following steps
7cadbfd
to
fdbdd4c
Compare
fdbdd4c
to
c791215
Compare
This CI action does the following actions: Build the process_monitor.sys bpf program and the ntosebpfext.sys driver it depends on. These programs are uploaded as artifacts. Build tetragon.exe and tetra,exe on a Windows worker and uploads them asartifacts. Downloads the artifacts and installs them. A file setup-windows.ps1 is added to facilitate this step. It then downloads the ebpf-for-windows build and installs it. Runs tetragon.exe and launches a process to see if an event is received. Signed-off-by: Anadi Anadi <[email protected]>
c791215
to
e299488
Compare
Description
This CI action does the following actions: