Fix / clean up repo-docker-run.sh #3654
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some readlink implementations (like the that comes with Mac) doesn't support -e flag. This script already uses the realpath command, so let's use that everywhere. Signed-off-by: Michi Mutsuzaki <[email protected]>
The top-level directory is two levels up. Signed-off-by: Michi Mutsuzaki <[email protected]>
In my environment "make -C api" fails depending on timing with this
error:
buf breaking /src/api --against "/src/api/../.git#branch=origin/main,subdir=api/v1"
Failure: could not clone file:///src/.git: exit status 128
fatal: detected dubious ownership in repository at '/src/.git'
To add an exception for this directory, call:
git config --global --add safe.directory /src/.git
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
make: Leaving directory '/src/api'
make: *** [Makefile:30: __check-breaking_local] Error 1
make: *** [all] Error 2
Update repo-docker-run.sh to check if it's in the main git working copy
before mounting .git. This script doesn't need to mount .git directory
separately if it's already running in the main git working copy since it
will be in the main volume mount under /src/.
Signed-off-by: Michi Mutsuzaki <[email protected]>
For those people who don't have docker installed. Signed-off-by: Michi Mutsuzaki <[email protected]>
Don't pass --rm and --user flags to repo-docker-run.sh. The script sets these flags. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added
the
release-note/misc
mtardy
approved these changes
Apr 22, 2025
joestringer
reviewed
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably easier to review commit by commit.