chore(tetragon): consolidate action verification checks #4077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwindsor
added
release-note/bug
dwindsor
changed the title
dwindsor
changed the title
olsajiri
reviewed
Sep 5, 2025
pkg/sensors/tracing/generickprobe.go
Outdated
| } | ||
|
|
||
| if selectors.HasSigkillAction(f) && !config.EnableLargeProgs() { | ||
| if selectors.HasAction(f, "sigkill") && !config.EnableLargeProgs() { |
Contributor
There was a problem hiding this comment.
maybe using ActionType... constants would be less error prone, like:
if selectors.HasAction(f, ActionTypeSigKill)
dwindsor
force-pushed
the
david/combine-check-actions
branch
3 times, most recently
from
b37831b to
c81df36
Compare
Signed-off-by: David Windsor <[email protected]>
dwindsor
force-pushed
the
david/combine-check-actions
branch
from
c81df36 to
9951075
Compare
Signed-off-by: David Windsor <[email protected]>
dwindsor
force-pushed
the
david/combine-check-actions
branch
from
9951075 to
409935e
Compare
olsajiri
approved these changes
Sep 12, 2025
| act := strings.ToLower(s.MatchActions[j].Action) | ||
| if act == "sigkill" { | ||
| // HasAction returns true if any selector in the KProbeSpec has the specified action | ||
| func HasAction(kspec *v1alpha1.KProbeSpec, actionName string) bool { |
Contributor
There was a problem hiding this comment.
do we have user for this one?
Contributor
Author
There was a problem hiding this comment.
nope let's remove it, thanks
kkourt
approved these changes
Sep 17, 2025
Member
|
is it ready to be merged? Because it's approved but there's a comment on removing stuff that has not been removed yet iiuc, cc @dwindsor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4076
Description
Changelog