-
Notifications
You must be signed in to change notification settings - Fork 474
install/kubernetes/tetragon: Helm chart add serviceAnnotations and serviceLabels #4082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
install/kubernetes/tetragon: Helm chart add serviceAnnotations and serviceLabels #4082
Conversation
mtardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋 I'm really sorry it looks like this PR was overlooked. I think it makes sense. Could you take a look at the CI errors and fix your patch, you might need to run make -C install/kubernetes and maybe shorten your commit title (use make checkpatch to see, might need a rebase to get that).
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I will create a PR again in compliance with the above. |
|
Any chance you could squash everything and force push this? |
ddb2d3e to
37c3c0c
Compare
3f04b52 to
a20f128
Compare
…abels charts: add serviceAnnotations and serviceLabels for additive Service metadata management Tetragon Helm chart currently exposes only serviceLabelsOverride which forces full replacement of the Service labels and makes day to day label management error prone. This patch fixes this by adding: A new values key serviceLabels as an empty map in values.yaml to allow appending labels without losing chart defaults. A new values key serviceAnnotations as an empty map in values.yaml to allow appending annotations without losing chart defaults. Service template logic that preserves compatibility. If serviceLabels is set it is merged with existing chart labels or serviceLabelsOverride to produce the final label set. If serviceAnnotations is set it is merged with existing chart annotations to produce the final annotations set. As a secondary note, these additive fields can simplify label based selection in systems such as Prometheus. Signed-off-by: Lyon <[email protected]>
a20f128 to
36f271f
Compare
charts: add serviceAnnotations and serviceLabels for additive Service metadata management
Tetragon Helm chart currently exposes only serviceLabelsOverride which forces full replacement of the Service labels and makes day to day label management error prone.
This patch fixes this by adding:
A new values key serviceLabels as an empty map in values.yaml to allow appending labels without losing chart defaults.
A new values key serviceAnnotations as an empty map in values.yaml to allow appending annotations without losing chart defaults.
Service template logic that preserves compatibility. If serviceLabels is set it is merged with existing chart labels or serviceLabelsOverride to produce the final label set. If serviceAnnotations is set it is merged with existing chart annotations to produce the final annotations set.
Example values:
As a secondary note, these additive fields can simplify label based selection in systems such as Prometheus.