-
Notifications
You must be signed in to change notification settings - Fork 474
docs(assets/scss): Remove useless horizontal scrollbar #4199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tetragon website's style leads to a horizontal scrollbar due to overflowing from few pixels. This patch fixes this by adding: 1. `overflow-x: hidden` to the body element. By adding `overflow-x: hidden`, it hides the few pixels overflowing and removes the useless scrollbar. It does not move any other element, only removes the scrollbar. Tried to apply `overflow-x: hidden` on child component `<div class="container-fluid td-outer"></div>` but it disables the `sticky` position on some page containing a `nav` div. The only way I found to remove this useless horizontal scrollbar is to apply this style to the `body` element. Signed-off-by: Damien <[email protected]> Signed-off-by: Damien <[email protected]>
Linking the new body.scss created at commit 8831d29. Patching the useless horizontal scrollbar. Signed-off-by: Damien <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mtardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for this, while I agree with this change, I think it would be better to fix the cause of this instead of just masking the symptoms
To what I understand it's the Get hands-on with Tetragon that is too wide and is getting extra space for some reason, would you like to take a look by any chance? :)
|
Hello, I saw that some elements width with 100vw overflow the parent element, I think that's the problem. I might take a look in the following days. |
If you want to look it up that would be amazing otherwise we can always open an issue for it later on. No pressure. |
|
I will take a look maybe this week or the next week, yes! |
Description
Added
overflow-x: hidden;style to thebodyelement to remove the useless horizontal scrollbar.Before patch:

After patch:
