-
Notifications
You must be signed in to change notification settings - Fork 490
tetragon/pkg: add user-configurable BPF_F_NO_PREALLOC flag support #4340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
tetragon/pkg: add user-configurable BPF_F_NO_PREALLOC flag support #4340
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
24d75a6 to
100c6e6
Compare
mtardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me but let's see if that would be better to have a global flag instead of a per map flag for NO_PREALLOC disable since you mentioned another map in the issue. I'm really not sure which one is best 🤔
We could even extend this flag to the map we already have using no_prealloc, but maybe that's too much for this patch set and out of scope!
100c6e6 to
7bdfbdf
Compare
780db2d to
a34a05e
Compare
|
is it ready for re-review @kyledong-suse ? :) |
|
@mtardy @kkourt I have modified the implementation regarding to the discussion in #4249 |
olsajiri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heya, looks good, left some comments
I need to check the issue properly, but did we discuss performance implications? I guess policy_filter_maps is fine, I'm not sure override_task is that straight forward
thanks
It has been discussed a bit in the issue. Additionally, #4204 proposed an idea to use shared |
a34a05e to
9438ba6
Compare
This commit adds support for controlling the BPF_F_NO_PREALLOC flag on BPF maps through CLI flags. Users can now disable preallocation globally or for specific maps to reduce memory usage. Fixes: cilium#4249 Signed-off-by: Kyle Dong <[email protected]>
9438ba6 to
5d5bd6e
Compare
Signed-off-by: Kyle Dong <[email protected]>
|
@kyledong-suse I think it's ok, I have one more idea for the code, please check 4705b87
just to make sure I understand the options semantics.. we either enable no-prealloc for all allowed maps (via SetNoPreAlloc) with |
Description
This commit adds support for controlling the BPF_F_NO_PREALLOC flag on BPF maps through CLI flags. Users can now disable preallocation globally or for specific maps to reduce memory usage.
Fixes: #4249