tetragon: assorted fixes #4376
Open
tetragon: assorted fixes #4376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can store parent and ancestors for loader events as well. Signed-off-by: Jiri Olsa <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
Currently we do not store parent for loader event. There's no real reason for that, so let's have it in the same way with process/parent/ancestors as we have for other tracing events. Signed-off-by: Jiri Olsa <[email protected]>
To keep global has bools, adding sleepableOffload for now, one more is coming shortly. Signed-off-by: Jiri Olsa <[email protected]>
We have read_reg/write_regs in uprobe_offload.h and generic_calls.h, add just one copy to regs.h. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
added
the
release-note/minor
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
FedeDP
reviewed
Nov 24, 2025
|
|
||
| if in.useMulti { | ||
| progs, maps, err = createMultiUprobeSensor(name, ids, polInfo.name, hasSleepableOffload) | ||
| progs, maps, err = createMultiUprobeSensor(name, ids, polInfo.name, &has) |
Contributor
There was a problem hiding this comment.
I'd pass has by value here; while it might be a little worse in term of performance, it clearly states that we are not going to play with the pointed data (ie: that has as seen from the caller is const). WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding fixes/cleanup for loader events and register read/write