-
Notifications
You must be signed in to change notification settings - Fork 490
fix(tests): Unit Test for LSM CGroup Tracking Map Fix #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): Unit Test for LSM CGroup Tracking Map Fix #4418
Conversation
325fe07 to
cb76a5e
Compare
FedeDP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
|
Oh @ariosmon i just noticed that the commit message is a bit off, seems like you should |
aa61900 to
8195826
Compare
|
@FedeDP I've added a new commit message, I think is good now 👍 |
|
👋 Hello @mtardy I'll appreciate if you can take a look and add your comments or merge if you agree 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey 👋, thanks for the new test, which fix is this testing against? Could you link to it in the commit description? you can use this command to reference commit:
[alias]
cite = "!f() { git log -1 '--pretty=format:%H (\"%s\")%n' $1 | sed -e 's/\\([0-f]\\{12\\}\\)[0-f]*/\\1/'; }; f"8195826 to
c4ea628
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6c1e555 to
84cf5a1
Compare
Add TestLSMCgTrackerMap to validate that tg_cgtracker_map is correctly included in LSM sensors when EnableCgTrackerID is enabled. The test verifies both cases (enabled and disabled) to prevent regressions of the cgtracker map loading logic introduced in commit 2e3ec05 Fix tg_cgtracker_map size in LSM generic probes Signed-off-by: ariosmon <[email protected]>
mtardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
|
ah checkpatch seeing that it's the wrong commit ID, you pulled the one from the PR on your fork not the one that got merge on main. Not a huge deal but the correct one is 2e3ec05. |
84cf5a1 to
90014af
Compare
|
👋 Hello @mtardy thanks for your comments, I already added the requested comment in the commit and all list of jobs are good, can you take a look? if you agree please get merge it, thanks in advance 👍 |
Description
Adds unit test for LSM cgroup tracking map fix.
Testing
Test passes on Linux with both
EnableCgTrackerIDenabled and disabled cases.