new: event log grpc service #4508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Di Pierro <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
FedeDP
force-pushed
the
new/logservice
branch
from
cfb288d to
2005c43
Compare
FedeDP
commented
Jan 12, 2026
| // Error if exportFilename points to a directory | ||
| return errors.New("passed export JSON logs file point to a directory") | ||
| } | ||
| logFile := filepath.Base(option.Config.ExportFilename) |
Contributor
Author
There was a problem hiding this comment.
Moved to be internally managed by exporter.
FedeDP
added
the
release-note/minor
FedeDP
force-pushed
the
new/logservice
branch
2 times, most recently
from
35e04d1 to
e4020a7
Compare
When created, it receives a list of setters, that need to implement the `eventLogParamsSetter` interface, and subsequently it will act on all of them, requesting log params changes. The server also caches latest requested params to be returned by the `GetLogParams` grpc API. Signed-off-by: Federico Di Pierro <[email protected]>
Also, in tetragon main, split `startExporter` in `getExporter` + `exporter.Start()`. This is because we need to fetch the exporter before start service the logservice server, but we want to start the exporter after. Moreover, let exporter manage log file rotation internally, to allow it to eventually update the rotation params. Finally, let exporter implement `eventLogParamsSetter`. Signed-off-by: Federico Di Pierro <[email protected]>
It allows setting and getting logging parameters for event exporter. Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
new/logservice
branch
from
e4020a7 to
9229742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new grpc service that allows to request rotation log params changes to event log exporter.
Changelog