Skip to content

process cache: metric for implicit evictions #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkourt merged 1 commit into from
Jan 29, 2026
Merged

process cache: metric for implicit evictions #4574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/content/en/docs/reference/metrics.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/process/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ func (pc *Cache) add(process *ProcessInternal) bool {
evicted := pc.cache.Add(process.process.ExecId, process)
if !evicted {
processCacheTotal.Inc()
} else {
processCacheCapacityEvictions.Inc()
}
return evicted
}
Expand Down
7 changes: 6 additions & 1 deletion pkg/process/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ var (
processCacheEvictions = prometheus.NewCounter(prometheus.CounterOpts{
Namespace: consts.MetricsNamespace,
Name: "process_cache_evictions_total",
Help: "Number of process cache LRU evictions.",
Help: "Number of process cache LRU evictions. This includes all evictions: both explicit and capacity (implicit).",
})
processCacheCapacityEvictions = prometheus.NewCounter(prometheus.CounterOpts{
Namespace: consts.MetricsNamespace,
Name: "process_cache_capacity_evictions_total",
Help: "Number of process cache capacity (implicit) LRU evictions.",
})
processCacheMisses = metrics.MustNewCounter(metrics.NewOpts(
consts.MetricsNamespace, "", "process_cache_misses_total",
Expand Down
Loading