Add keyChar() event; modifier support for FileDropEvent#2388
Merged
Conversation
Introduces a separate keyChar() callback and signal for character input, distinct from keyDown/keyUp. This properly handles IME, dead keys, and composed characters (e.g., ' + e = é). - Add virtual keyChar() to AppBase - Add getSignalKeyChar() and emitKeyChar() to Window - Implement GLFW character callback with per-window key data storage - Implement Windows WM_CHAR handling with WM_DEADCHAR filtering - Update CinderImGui to use keyChar for text input with UTF-16 surrogate support
Allows detecting Shift, Ctrl, Alt, and Meta keys during file drops. Backwards-compatible API with default parameter. - Add modifier accessors to FileDropEvent (isShiftDown, isAltDown, etc.) - Pass modifiers from GLFW and Windows implementations
- Enable keyChar signal connection and handler - Display modifier keys on file drop events
Contributor
|
This is great -- thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keyChar()App-level virtual method andgetSignalKeyChar()for text input handling'+e=é)FileDropEvent(Shift, Ctrl, Alt, Meta) on macOS and WindowskeyCharfor text inputWhen to use keyChar() vs keyDown()/keyUp()
Use
keyChar()for text entry - when you need the actual character the user intended to type. Handles dead keys, IME, AltGr combinations, and non-English layouts correctly.Use
keyDown()/keyUp()for controls and shortcuts - when you need to detect physical key presses regardless of text output (e.g., WASD movement, hotkeys, game controls).Related Issues