Load Thumbnail first and fall back to the original image if it cannot be loaded #2445
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
🤔 Maybe let users control the max pixels of width and height of thumbnail is a better idea? |
|
I have read the CLA Document and I hereby sign the CLA |
Buer-Nahida
changed the title
… image When viewing messages, thumbnails are loaded first, if loading fails, the original image is loaded as a fallback.
| const decrypt = (encBuf: ArrayBuffer) => decryptFile(encBuf, mimeType ?? FALLBACK_MIMETYPE, encInfo); | ||
| let fileContent; | ||
| try { | ||
| fileContent = await downloadEncryptedMedia(mediaUrl, decrypt); | ||
| } catch { | ||
| fileContent = await downloadEncryptedMedia(mxcUrlToHttp(mx, url, useAuthentication) ?? url, decrypt); | ||
| } |
There was a problem hiding this comment.
we should always use the original url for encrypted image as it is always going to fail to generate thumbnail for it.
| if (useThumbnail) { | ||
| setUseThumbnail(false); | ||
| loadSrc(); | ||
| } else { | ||
| setLoad(false); | ||
| setError(true); | ||
| } |
There was a problem hiding this comment.
is there any particular reason to use this fallback strategy?
| > | ||
| {renderViewer({ | ||
| src: srcState.data, | ||
| src: useThumbnail ? (mxcUrlToHttp(mx, url, useAuthentication) ?? url) : srcState.data, |
There was a problem hiding this comment.
since encrypted message always going to use full image we should use srcState.data for them and url for normal images.
| } | ||
|
|
||
| if (msgType === MsgType.Image) { | ||
| const content: IImageContent = getContent(); |
There was a problem hiding this comment.
IImageContent already provide the thumbnail image along with dimensions, should not we be passing that to ImageContent component?
| resizeMethod: string | ||
| } | undefined; | ||
| if (width && height) { | ||
| const scale = (width > height ? width : height) / 800; |
There was a problem hiding this comment.
we already has a standard thumbnail scaling function getThumbnailDimensions which is used to generate the thumbnail while sending images.
| url?: string; | ||
| info?: IImageInfo & IThumbnailContent; | ||
| file?: IEncryptedFile; | ||
| info?: { h: number, w: number }; |
There was a problem hiding this comment.
info is already described at line 50.
3 participants
Description
When viewing messages, thumbnails are loaded first, if loading fails, the original image is loaded as a fallback.
Type of change
Checklist: