-
-
Notifications
You must be signed in to change notification settings - Fork 361
Add all public servers; Make menu scrollable #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
kfiven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be added to this list, a server must:
- have open registration
- their registration method should be supported in Cinny
- should be reputable
- login/register flow needs to be tested before adding.
A quick check shows few of server offline, closed registration.
How to objectively measure this?
So I need to test the login and registration flow for every single one of these servers, in order for them to get added? |
|
To measure server reputation, I usually check how long they are operating, downtime, if they are blocked or not in community moderation list or matrix.org block list. Yes we need to test the flows as it will feel broken if these features are not working because some server only allow registration from their choice of client. |
Great! In that case all of them fulfil those requirements, see here https://servers.joinmatrix.org/operators.html (those 3 are requirements manually checked by the list maintainer).
Ok, in that case I will make a dummy account on all those servers and test registration flow. Is it ok that I just confirm the working ones, or do I need to screen record all of the tests? This can be quite time-consuming, honestly. |
|
Yeah, just testing is enough. No need to record. |
| overflowY: 'auto', | ||
| WebkitOverflowScrolling: 'touch', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use Scroll component from folds for scrollable container. Other "menus" can be looks for ref.
| "sans-nuage.fr", | ||
| "libreon.fr", | ||
| "transgirl.cafe", | ||
| "deuxfleurs.fr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
servers should be sorted A-Z? @kfiven
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Description
Summary
Appended all public homeservers to the current list, and made it scrollable because with current styling it couldn't be displayed well.
Motivation
Today's downtime of
matrix.orghomesever, that forced me to federate, and I wanted to keep using Cinny for it.Code context
Integrates correctly with the current codebase, the only changes are some lines appended to
config.jsonand a minor style edit inServerPicker.tsx. A preview of this functionality can be found on my fork: https://cinnyapp.pages.devType of change
Checklist: