Skip to content

Fix space room reorder#2573

Closed
lhjt wants to merge 1 commit into
cinnyapp:devfrom
lhjt:fix/first-time-reorder
Closed

Fix space room reorder#2573
lhjt wants to merge 1 commit into
cinnyapp:devfrom
lhjt:fix/first-time-reorder

Conversation

@lhjt
Copy link
Copy Markdown

@lhjt lhjt commented Jan 17, 2026

Description

  • Prevent duplicate entries during same-space drag reorder by removing the dragged room before reinserting
  • Ensure a single m.space.child update per room when reordering within a space
  • This issue manifested itself as failing to update space room ordering when dragging a room upwards for the first time

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@lhjt lhjt closed this by deleting the head repository Feb 7, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 13, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 15, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 15, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 15, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 15, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 16, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 18, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 18, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 23, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 23, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 23, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 24, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 24, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 25, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 26, 2026
smokku added a commit to smokku/cinny that referenced this pull request Mar 26, 2026
smokku added a commit to smokku/cinny that referenced this pull request Apr 1, 2026
smokku added a commit to smokku/cinny that referenced this pull request May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant