fix(reactions): keep reaction pill order stable when counts change#3045
Open
LucienLassalle wants to merge 1 commit into
Open
fix(reactions): keep reaction pill order stable when counts change#3045LucienLassalle wants to merge 1 commit into
LucienLassalle wants to merge 1 commit into
Conversation
Reaction pills were reordered by matrix-js-sdk on every add/remove, sorting by descending reaction count. This made a pill jump position whenever its count changed relative to others. Order reactions by the timestamp of their first occurrence instead, so a pill keeps its position once added, regardless of later count changes. Thanks to Syoshiii (https://github.com/Syoshiii) for reporting the issue. Signed-off-by: Lucien Lassalle <ravagnierlucas@gmail.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Jul 22, 2026
Author
|
recheck |
|
Preview: https://3045--cinny-pr.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When two reactions are equivalent in terms of "clicks" and someone decides to click the second one, that reaction moves to the first position; this could cause another person intending to click it to make a mistake.
The issue was reported to me by @Syoshiii , who brought it to my attention on my server.
This is my first PR for Cinny; please feel free to provide feedback.
The commit was made with Claude's help.