Allow upload URL to be specified for analytics#22
Open
pseudonymtim wants to merge 2 commits intocircleci:masterfrom
Open
Allow upload URL to be specified for analytics#22pseudonymtim wants to merge 2 commits intocircleci:masterfrom
pseudonymtim wants to merge 2 commits intocircleci:masterfrom
Conversation
pseudonymtim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
circleci.analytics-clj.core/initializefunction does not allow the upload URL to be set on the Analytics builder. This prevents clients from specifying a completely different URL to which to send events. Specifying theendpointreplaces the host and path prefix, but the underlying segmentio/analytics-java code appends a default path of/v1/import/(as per com/segment/analytics/Analytics.java#L187) to the value of endpoint when building the Analytics object.Solution
Add the
upload-urlargument & associatedupload-url*function to access thesetUploadURLAnalytics builder method to allow the full URL to be specified by the client.