IP ranges updates #9328
Open
IP ranges updates #9328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaningo
reviewed
Apr 15, 2025
jekyll/_cci2/ip-ranges.adoc
Outdated
|
|
||
| Use conditional logic to control when IP ranges is enabled with pipeline parameters. | ||
| Use conditional logic to control when IP ranges is enabled with pipeline parameters. You can set the pipeline parameter `pipeline.parameters.ip_ranges` to `true` to enable IP ranges for the `build` job. FOr more information on triggering pipelines with pipeline parameters, see the xref:triggers-overview#[Trigger a pipeline] page. |
There was a problem hiding this comment.
In that example, the parameter's name is ip_ranges. The notation pipeline.parameters.ip_ranges is how you refer to the parameter.
Typo: FOr.
There was a problem hiding this comment.
Just checking - are you suggesting a change to the paragraph here? I've fixed the FOr typo but from your comment it seems like I need to do something else?
yaningo
reviewed
Apr 15, 2025
jekyll/_cci2/ip-ranges.adoc
Outdated
| * link:https://ip-ranges.amazonaws.com/ip-ranges.json[AWS]: CircleCI uses the _us-east-1_ and _us-east-2_ regions. | ||
| * link:https://www.gstatic.com/ipranges/cloud.json[GCP]: CircleCI uses the _us-east1_ and _us-central1_ regions. | ||
|
|
||
| CircleCI _does not recommend_ configuring an IP-based firewall using the AWS or GCP IP addresses. The vast majority are not CircleCI's machines. CircleCI can _not guarantee_ that the addresses in the AWS or GCP endpoints persist from day-to-day, as these addresses are reassigned continuously. |
There was a problem hiding this comment.
Due to the security aspect, I think this paragraph could be a "CAUTION".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reasons
The flow of the page was confusing, combining information on the feature "IP Ranges" and also the IP adresses customers can expect core CircleCI services to use. This page is in our top 10 most read so we wanted to make changes to improve readability and structure.
Content Checklist
Please follow our style when contributing to CircleCI docs. Our style guide is here: https://circleci.com/docs/style/style-guide-overview.
Please take a moment to check through the following items when submitting your PR (this is just a guide so will not be relevant for all PRs) 😸: