UI 🧹 consolidate colours into CSS variables #9986
Open
rosieyohannan wants to merge 3 commits intomainfrom
Open
UI 🧹 consolidate colours into CSS variables #9986rosieyohannan wants to merge 3 commits intomainfrom
rosieyohannan wants to merge 3 commits intomainfrom
Conversation
…paration Converted 92 hard-coded color values to CSS variables across the UI codebase to prepare for dark mode implementation. This systematic refactoring creates a unified color system that will enable easy theme switching. Changes: - Reorganized vars.css with clear sections (base palette vs semantic tokens) - Fixed admonition color mismatches between definitions and usage - Consolidated Tailwind @theme colors to reference vars.css - Converted all hard-coded colors in doc.css (28), toc.css (2), tabs.css (3) - Made syntax highlighting theme-aware (highlight.css, shiki.css) - Added color-scheme metadata to base.css - Fixed undefined --spacing variable (pre-existing bug) - Created comprehensive COLOR_SYSTEM.md documentation The codebase now has 185 CSS variables organized into: - Base color palette (36 variables) - Semantic tokens for light theme (80+ variables) - Syntax highlighting colors (17 variables) - Font, dimension, and z-index properties All changes maintain visual parity with the current design. Build passes cleanly with no CSS errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed pre-existing stylelint warnings to improve code quality and consistency: - Updated rgba() to modern rgb() notation with percentage alpha values - Changed hex color #FFFFFF to shorter form #FFF - Renamed CSS variables to use consistent kebab-case naming: - --link_hover-font-color → --link-hover-font-color - --link_unresolved-font-color → --link-unresolved-font-color - --scrollbar_hover-thumb-color → --scrollbar-hover-thumb-color - --navbar_hover-background → --navbar-hover-background - --navbar-menu_hover-background → --navbar-menu-hover-background - Replaced deprecated word-wrap with overflow-wrap All changes are cosmetic and maintain visual parity. Build passes with zero lint errors. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rosieyohannan
changed the title
ui 🧹 style lint fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dark mode preparation
Converted 92 hard-coded colour values to CSS variables across the UI codebase to prepare for dark mode implementation. This systematic refactoring creates a unified colour system that will enable easy theme switching.
Changes:
The codebase now has 185 CSS variables organized into:
All changes maintain visual parity with the current design.