Skip to content

Allow setting framework, but default to "Ring" #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raycheung wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow setting framework, but default to "Ring" #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a454633
Allow setting framework, but default to "Ring"
Jun 12, 2018
807ba25
Merge branch 'master' into master
marcomorain Sep 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/circleci/rollcage/core.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,9 @@

(s/defn ^:private client* :- Client
[access-token :- (s/maybe String)
{:keys [os hostname environment code-version file-root result-fn]
:or {environment "production"}}]
{:keys [os hostname environment framework code-version file-root result-fn]
:or {environment "production"
framework "Ring"}}]
(let [os (or os (guess-os))
hostname (or hostname (guess-hostname))
file-root (or file-root (guess-file-root))
Expand All @@ -178,7 +179,7 @@
:data {:environment (name environment)
:platform (name os)
:language "Clojure"
:framework "Ring"
:framework (name framework)
:notifier {:name "Rollcage"}
:server {:host hostname
:root file-root
Expand Down