Allow person data to be sent through the API#54
Open
skuro wants to merge 1 commit intocircleci:masterfrom
Open
Allow person data to be sent through the API#54skuro wants to merge 1 commit intocircleci:masterfrom
skuro wants to merge 1 commit intocircleci:masterfrom
Conversation
Fixes circleci#53 by allowing a `:person` map to be passed through the API call, without breaking any existing API contract
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 92.20% 89.16% -3.05%
==========================================
Files 4 4
Lines 231 240 +9
Branches 5 5
==========================================
+ Hits 213 214 +1
- Misses 13 21 +8
Partials 5 5
Continue to review full report at Codecov.
|
marcomorain
reviewed
Sep 28, 2021
Contributor
marcomorain
left a comment
marcomorain
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I think we can modify make-rollbar to alwaya take a person argument.
I should probably write more docs now that more folks are using this library :)
| url :- (s/maybe String) | ||
| custom :- (s/maybe {s/Any s/Any})] | ||
| custom :- (s/maybe {s/Any s/Any}) | ||
| & [person :- {:id String |
Contributor
There was a problem hiding this comment.
make-rollbar is only called in one place, and it's private, so we should be able to make the new argument a required parameter, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53 by allowing a
:personmap to be passed through the Rollbar API call, without breaking any existing API contract