-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONPREM-1829] [HACKWEEK] Add initial support for Windows containers #96
Open
christian-stephen
wants to merge
11
commits into
main
Choose a base branch
from
cs/windows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-stephen
force-pushed
the
cs/windows
branch
5 times, most recently
from
December 21, 2024 14:52
0cac44a
to
3675af7
Compare
christian-stephen
changed the title
[DRAFT] Support Windows containers
[ONPREM-1829] Support Windows containers
Jan 6, 2025
christian-stephen
changed the title
[ONPREM-1829] Support Windows containers
[ONPREM-1829] [HACKWEEK] Support Windows containers
Jan 7, 2025
christian-stephen
changed the title
[ONPREM-1829] [HACKWEEK] Support Windows containers
[ONPREM-1829] [HACKWEEK] Add initial support for Windows containers
Jan 7, 2025
christian-stephen
changed the title
[ONPREM-1829] [HACKWEEK] Add initial support for Windows containers
[ONPREM-1829] [HACKWEEK] Add support for Windows containers
Jan 7, 2025
christian-stephen
changed the title
[ONPREM-1829] [HACKWEEK] Add support for Windows containers
[ONPREM-1829] [HACKWEEK] Add initial support for Windows containers
Jan 7, 2025
Appears we don't have privileges to create symlinks
christian-stephen
force-pushed
the
cs/windows
branch
from
January 29, 2025 22:12
71f270b
to
777b09d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ Issue
https://circleci.atlassian.net/browse/ONPREM-1829
⚙️ Change Description
This PR adds support for Windows on container runner. The only updates were made to GOAT and the
runner-init
image. Some changes to the process and signal handling in GOAT needed to be made since it was Linux-centric. In addition, the binary and images needed to be updated in order to target Windows. The base image forrunner-init
needed to also be based on a Windows image, since a container OS is required for Windows, which have been added to the manifest.Example job using a Windows container: https://app.circleci.com/pipelines/github/circleci/runner-dummy/3006/workflows/ccc16261-2422-41a3-8a99-bbd06ad7c6e7/jobs/193687?invite=true#step-102-42_67
The only known limitation of Windows containers is that service containers are currently unsupported. This will be addressed in a followup ticket (ONPREM-1830), which will require targeting Windows for the
logging-collector
binary and image.Acceptance Criteria:
✅ Solution
❓ Testing
📖 Documentation Updates