Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONPREM-1829] [HACKWEEK] Add initial support for Windows containers #96

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

christian-stephen
Copy link
Member

@christian-stephen christian-stephen commented Dec 19, 2024

⚙️ Issue

https://circleci.atlassian.net/browse/ONPREM-1829


⚙️ Change Description

This PR adds support for Windows on container runner. The only updates were made to GOAT and the runner-init image. Some changes to the process and signal handling in GOAT needed to be made since it was Linux-centric. In addition, the binary and images needed to be updated in order to target Windows. The base image for runner-init needed to also be based on a Windows image, since a container OS is required for Windows, which have been added to the manifest.

Example job using a Windows container: https://app.circleci.com/pipelines/github/circleci/runner-dummy/3006/workflows/ccc16261-2422-41a3-8a99-bbd06ad7c6e7/jobs/193687?invite=true#step-102-42_67

The only known limitation of Windows containers is that service containers are currently unsupported. This will be addressed in a followup ticket (ONPREM-1830), which will require targeting Windows for the logging-collector binary and image.

Acceptance Criteria:


Solution


Testing


📖 Documentation Updates

  • Updated related documentation, if applicable
  • Updated changelog

@christian-stephen christian-stephen force-pushed the cs/windows branch 5 times, most recently from 0cac44a to 3675af7 Compare December 21, 2024 14:52
@christian-stephen christian-stephen changed the title [DRAFT] Support Windows containers [ONPREM-1829] Support Windows containers Jan 6, 2025
@christian-stephen christian-stephen marked this pull request as ready for review January 7, 2025 15:13
@christian-stephen christian-stephen requested a review from a team as a code owner January 7, 2025 15:13
@christian-stephen christian-stephen changed the title [ONPREM-1829] Support Windows containers [ONPREM-1829] [HACKWEEK] Support Windows containers Jan 7, 2025
@christian-stephen christian-stephen changed the title [ONPREM-1829] [HACKWEEK] Support Windows containers [ONPREM-1829] [HACKWEEK] Add initial support for Windows containers Jan 7, 2025
@christian-stephen christian-stephen changed the title [ONPREM-1829] [HACKWEEK] Add initial support for Windows containers [ONPREM-1829] [HACKWEEK] Add support for Windows containers Jan 7, 2025
@christian-stephen christian-stephen changed the title [ONPREM-1829] [HACKWEEK] Add support for Windows containers [ONPREM-1829] [HACKWEEK] Add initial support for Windows containers Jan 7, 2025
@christian-stephen christian-stephen marked this pull request as draft January 8, 2025 11:44
@christian-stephen christian-stephen marked this pull request as ready for review January 29, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant