fix: move hardcoded admin credentials to env vars and fix console.log syntax error#12
Open
bennytimz wants to merge 3 commits intocirclefin:masterfrom
Open
fix: move hardcoded admin credentials to env vars and fix console.log syntax error#12bennytimz wants to merge 3 commits intocirclefin:masterfrom
bennytimz wants to merge 3 commits intocirclefin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two related issues in lib/supabase/initialize-admin-user.ts:
The admin password (123456) was hardcoded directly in source code. Anyone with
read access to the repository knows the default admin password. If a developer
deploys this app without changing the password, the admin account is immediately
compromised.
Fix: The password is now read from a new ADMIN_PASSWORD environment variable.
The app logs a clear error and skips admin creation if the variable is not set,
rather than silently creating an account with a publicly known password.
The email already had an ADMIN_EMAIL env var in .env.example but the code
wasn't using it — that is also fixed here.
// Before (crashes at runtime — missing opening parenthesis)
console.log
Admin user with email ${adminEmail} created successfully.);// After (correct)
console.log(
Admin user with email ${adminEmail} created successfully.);This would cause an uncaught SyntaxError the first time the admin user is
successfully created, crashing the initialization function.
Files changed