fix: sync package lock with manifest#45
Open
westkite1201 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package-lock.jsonwith the currentpackage.jsondependency manifest.@circle-fin/developer-controlled-walletsfrom the stale8.4.1graph to10.6.0, which satisfies the existing^10.0.1package.json range.Why
package.jsonalready depends on@circle-fin/developer-controlled-wallets@^10.0.1, butpackage-lock.jsonstill listed the root dependency as^8.4.1and retained removed dependencies. A cleannpm installfails during dependency resolution because the manifest and lockfile disagree.Verification
npm install --package-lock-only --ignore-scriptsnpm ci --package-lock-only --ignore-scriptsgit diff --checkDuplicate check
Checked existing PRs for
developer-controlled-wallets,package-lock,npm install, andERESOLVE. The duplicate gate surfaced #34, but that PR is the OpenZeppelin webhook signature fix and does not modifypackage-lock.json, so this lockfile sync is separate.