fix: sort transaction history by numeric amount, not formatted text#6
Open
theyavuzarslan wants to merge 1 commit into
Open
fix: sort transaction history by numeric amount, not formatted text#6theyavuzarslan wants to merge 1 commit into
theyavuzarslan wants to merge 1 commit into
Conversation
The Amount column sorted on amount_formatted, a text column, so rows
ordered lexicographically ('100' < '20' < '3'). Sort on the numeric
amount column instead and keep amount_formatted for display only.
The amount column already exists in the schema; no migration needed.
theyavuzarslan
force-pushed
the
fix/numeric-amount-sort
branch
from
July 13, 2026 14:32
e1a7668 to
91611ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Amount column in the transaction history sorts on
amount_formatted, which is atextcolumn (the init migration definesamount numeric(78, 0)andamount_formatted text). Supabase orders it lexicographically, so "100" sorts before "20", which sorts before "3". Any mix of amounts with different digit counts comes back in the wrong order.The fix changes
SortColumnfrom"amount_formatted"to"amount"and updates theSortableHeadercolumn prop inTransactionHistory.tsx. The numericamountcolumn already exists, so there is no migration.amount_formattedis still what gets displayed. Both tokens in this app use 8 decimals, so ordering by raw units gives the same order as the displayed values.