fix(arc-testnet): correct nativeCurrency decimals from 6 to 18#21
Closed
Sertug17 wants to merge 1 commit into
Closed
fix(arc-testnet): correct nativeCurrency decimals from 6 to 18#21Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
Author
|
Closing this in favor of #19 by @Ccheh — I missed that PR while #19 covers the same Apologies @Ccheh — your PR is the right one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/circle/gateway-sdk.ts:47defines Arc Testnet's native currency as:However, Arc Testnet uses USDC as native gas with 18 decimals, while ERC-20 USDC uses 6. Because viem's chain config treats
nativeCurrency.decimalsas the value used forformatEther/formatUnitsdefaults and balance calculations, balances displayed via this chain config will be off by 10^12.Verification
The same chain config pattern was identified and corrected in
arc-multichain-wallet#37by @Ccheh, where the same fix was applied alongside additional corrections.Change
The
namefield was also updated from'USD Coin'to'USDC'for consistency with thesymbolfield (matching the change made in arc-multichain-wallet#37).Notes