fix: add ARC_TESTNET_RPC_KEY to .env.example and remove hardcoded fallback#29
Open
consumeobeydie wants to merge 1 commit into
Open
fix: add ARC_TESTNET_RPC_KEY to .env.example and remove hardcoded fallback#29consumeobeydie wants to merge 1 commit into
consumeobeydie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lib/circle/gateway-sdk.tsline 42 contains a hardcoded fallback RPC key:This key is not documented in
.env.exampleorREADME.md, so developers who clone the repo have no indication that this variable exists or that they should set it. The hardcoded fallback also means the key is exposed in the public repository.Fix
console.warnwhenARC_TESTNET_RPC_KEYis not setARC_TESTNET_RPC_KEYto.env.exampleARC_TESTNET_RPC_KEYto the Environment Variables table inREADME.mdChanges
.env.example— addedARC_TESTNET_RPC_KEY=your-arc-testnet-rpc-keylib/circle/gateway-sdk.ts— removed hardcoded fallback, added warningREADME.md— documented the variable in the env vars table