ci: add lint step to CI workflow and improve documentation#7
Open
dolepee wants to merge 1 commit intocirclefin:masterfrom
Open
ci: add lint step to CI workflow and improve documentation#7dolepee wants to merge 1 commit intocirclefin:masterfrom
dolepee wants to merge 1 commit intocirclefin:masterfrom
Conversation
- Add npm run lint step to CI workflow after dependency installation - Add detailed JSDoc comment for planned Circle Paymaster API integration in deposit.ts - Add CONTRIBUTING.md with development setup and contribution guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing lint step to the CI workflow and improves project documentation.
Changes
npm run lintstep after dependency installation. The job is namedlint-and-testbut was only installing dependencies without running the linter.Why