fix: use validated env in createAdminClient instead of raw process.env#7
Open
Sertug17 wants to merge 1 commit into
Open
fix: use validated env in createAdminClient instead of raw process.env#7Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
createAdminClient was reading NEXT_PUBLIC_SUPABASE_URL directly from process.env with a non-null assertion, bypassing the Zod validation in serverEnv/clientEnv. If the env var is missing at runtime, the error would be a cryptic cannot-read-property-of-undefined instead of the structured validation error from the schema. Also switched to clientEnv.NEXT_PUBLIC_SUPABASE_URL since this is a public (NEXT_PUBLIC_) variable validated in clientSchema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createAdminClient was reading NEXT_PUBLIC_SUPABASE_URL directly from process.env with a non-null assertion, bypassing the Zod validation in serverEnv/clientEnv. If the env var is missing at runtime, the error would be a cryptic cannot-read-property-of-undefined instead of the structured validation from the schema.
Also switched to clientEnv.NEXT_PUBLIC_SUPABASE_URL since this is a public (NEXT_PUBLIC_) variable that's validated in clientSchema.