fix(eip-1193): sign personal_sign payloads as raw bytes#33
Draft
danilaverbena wants to merge 1 commit into
Draft
fix(eip-1193): sign personal_sign payloads as raw bytes#33danilaverbena wants to merge 1 commit into
danilaverbena wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sign
personal_signchallenges as raw bytes instead of UTF-8 text.Detail
The EIP-1193 provider receives the
personal_signchallenge as a hex-encoded byte string. Passing that value directly to viem'ssignMessagetreats values such as0xdeadbeefas the UTF-8 text"0xdeadbeef", producing a signature over different bytes than the caller requested.This change passes the challenge through viem's
{ raw: challenge }form and adds a regression assertion covering the arguments sent to the smart account signer.Testing
jest --runInBand src/__tests__/providers/eip-1193/provider.test.ts(19 tests passed)tsc --project tsconfig.json --pretty false --noEmiteslint src/providers/eip-1193/provider.ts src/__tests__/providers/eip-1193/provider.test.tsgit diff --checkDocumentation
No documentation changes are required; this restores the expected
personal_signbehavior.