fix(eip-1193): make eth_getTransactionReceipt non-blocking#34
Draft
Alicepoltora wants to merge 1 commit into
Draft
fix(eip-1193): make eth_getTransactionReceipt non-blocking#34Alicepoltora wants to merge 1 commit into
Alicepoltora wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_getTransactionReceiptJSON-RPC request instead of waiting for a mined transactionnullresult for pending or unknown transactionsRoot cause and impact
EIP1193Providerdelegatedeth_getTransactionReceiptto viem'swaitForTransactionReceipt. That action polls until a receipt is available and has a default timeout, while the JSON-RPC method is a one-shot lookup that must returnnullwhen no receipt exists yet. As a result, callers could block until the polling timeout for pending or unknown transaction hashes.Testing
jest --runInBand(60 suites, 302 tests)tsc --project tsconfig.json --pretty --noEmiteslinton the changed source, test, and mock files