Skip to content

Fix validAfter boundary condition in EIP3009 authorization validation #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kewe63 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix validAfter boundary condition in EIP3009 authorization validation #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
726830e
Fix critical dependency conflict preventing npm install
Kewe63 Apr 10, 2026
db33158
Revert "Fix critical security vulnerabilities in stablecoin contracts"
Kewe63 Apr 10, 2026
93c7a5f
Fix critical memory offset bug in FiatTokenUtil
Kewe63 Apr 10, 2026
dde6ae8
Fix validAfter boundary condition in EIP3009 authorization validation
Kewe63 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/v2/EIP3009.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ abstract contract EIP3009 is AbstractFiatTokenV2, EIP712Domain {
uint256 validBefore
) private view {
require(
now > validAfter,
now >= validAfter,
"FiatTokenV2: authorization is not yet valid"
);
require(now < validBefore, "FiatTokenV2: authorization is expired");
Expand Down
7 changes: 5 additions & 2 deletions contracts/v2/FiatTokenUtil.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,11 @@ contract FiatTokenUtil {
address addr1;
address addr2;
assembly {
addr1 := mload(add(packed, 20))
addr2 := mload(add(packed, 40))
// Account for 32-byte length prefix in memory
// First address starts at offset 32 (after length field)
addr1 := mload(add(packed, 32))
// Second address starts at offset 52 (32 + 20 bytes of first address)
addr2 := mload(add(packed, 52))
}
return abi.encode(addr1, addr2);
}
Expand Down